Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1611800401-9790-1-git-send-email-bingjingc@synology.com>
In-Reply-To: <1611800401-9790-1-git-send-email-bingjingc@synology.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Thu, 28 Jan 2021 09:32:47 +0100
Message-ID: <CAJfpegtDbDzSCgv-D66-5dAA=pDxMGN_aMTVcNPzWNibt2smLw@mail.gmail.com>
Subject: Re: [PATCH 3/3] parser: add unsigned int parser
To:     bingjingc <bingjingc@synology.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        cccheng@synology.com, robbieko@synology.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 28, 2021 at 3:21 AM bingjingc <bingjingc@synology.com> wrote:
>
> From: BingJing Chang <bingjingc@synology.com>
>
> Will be used by fs parsing options
>
> Reviewed-by: Robbie Ko<robbieko@synology.com>
> Reviewed-by: Chung-Chiang Cheng <cccheng@synology.com>
> Signed-off-by: BingJing Chang <bingjingc@synology.com>
> ---
>  fs/isofs/inode.c       | 16 ++--------------
>  fs/udf/super.c         | 16 ++--------------
>  include/linux/parser.h |  1 +
>  lib/parser.c           | 22 ++++++++++++++++++++++
>  4 files changed, 27 insertions(+), 28 deletions(-)
>
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 342ac19..21edc42 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -335,18 +335,6 @@ static const match_table_t tokens = {
>         {Opt_err, NULL}
>  };
>
> -static int isofs_match_uint(substring_t *s, unsigned int *res)
> -{
> -       int err = -ENOMEM;
> -       char *buf = match_strdup(s);
> -
> -       if (buf) {
> -               err = kstrtouint(buf, 10, res);
> -               kfree(buf);
> -       }
> -       return err;
> -}

I don't see how adding this function and removing it in the same
series makes any sense.

Why not make this the first patch in the series, simplifying everything?

And while at it the referenced fuse implementation can also be
converted (as a separate patch).

Thanks,
Miklos