Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210128081030.2345998-1-hsiufangho@google.com>
In-Reply-To: <20210128081030.2345998-1-hsiufangho@google.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Thu, 28 Jan 2021 10:04:42 +0100
Message-ID: <CAMpxmJWMMMNYj-U3WXGBa2GOO1xLze44ABnxnBo6-owgUwWwog@mail.gmail.com>
Subject: Re: [PATCH] eeprom: at24: Add permission to write_timeout
To:     Jenny Ho <hsiufangho@google.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 28, 2021 at 9:10 AM Jenny Ho <hsiufangho@google.com> wrote:
>
> Need to change timeout time for different use
> cases to prevent I2C error cases. Open the api
> and allow Read/Write permission to write_timeout
>
> Signed-off-by: Jenny Ho <hsiufangho@google.com>
> ---
>  drivers/misc/eeprom/at24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index 926408b41270..39caead4058c 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -117,7 +117,7 @@ MODULE_PARM_DESC(at24_io_limit, "Maximum bytes per I/O (default 128)");
>   * it's important to recover from write timeouts.
>   */
>  static unsigned int at24_write_timeout = 25;
> -module_param_named(write_timeout, at24_write_timeout, uint, 0);
> +module_param_named(write_timeout, at24_write_timeout, uint, 0600);
>  MODULE_PARM_DESC(at24_write_timeout, "Time (in ms) to try writes (default 25)");
>
>  struct at24_chip_data {
> --
> 2.30.0.280.ga3ce27912f-goog
>

IMO this should be a per-chip device property and not a global module
param. Any chance you could maybe try and extend the driver with a new
property for that?

Bart