Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp894994pxb; Thu, 28 Jan 2021 03:05:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0qiqTgIKPQPUvxhk+6fS/4/fG0KF6waaEtUvzlR/pNTTH0GSe32VMNXUIAYyR0nywD2oR X-Received: by 2002:a17:907:1b10:: with SMTP id mp16mr10656386ejc.482.1611831915415; Thu, 28 Jan 2021 03:05:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611831915; cv=none; d=google.com; s=arc-20160816; b=INsNy7I1ESFskBlxkRc/kx182dwYm0M2T97F36UVPE6yCCIvudSa3tJuGT/XY77/nx c33zWkw4WVhDnifuci7n+eEAywJ8hIpm3FSM/p7sDnxfuiq4owiYBghIR8CkDqEXv31C TW4GarfKRKSRpNjkMM25gyqqw2s4kxbPLNPg3Ciq+c8GsOwj3rhKwuBO8p7YvUA1Ls6d n3VxcXauhn6eKYpBzFKzwZj2P5wY72tdxr7FB4n/1LHh+8ep47m8maAlKL5jz/ILwwe6 gSLCuj7IpOzX+1O5NSmRANnJElQaM5nUTkHeclqVKy0MKXs4r2zGr4rWnBQhKhhpdQPh YykQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=0mPail6XTVdHrMZaCDEnu0VUutotPr6KtZ5kPtHXYxg=; b=s3OFhiv39gq4nnaLc/t9xnk40TudQUdfL1J8VknpEcn7u5WNNIgGAQk4V+p405uvKy u5kkv5jRJtoJNN3Wd0KOedTukmF+qMA3hVv1p96i8kyDSrOv2Kz6Y+tfJ7cpS1//Ba2k xSDLY/RLDqTRguslWS525+uJBSn+c0zY942wuFOZsd+QTy1a+9q5h5S2603A6RVUZuNj 2FrBHt9zg46c+ilaHnTlnPpe4+DbVaUTEyl71h/AeqiFCq+wrYlgeZqGzjwbEdMEeFxq u0aammjWysXacNDD3xF0ZnnH/Otba5idHd4iQd7U0oiYW4j3YZRd+HsWB83jaGHU9qjT xr6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cs9si2052808ejc.113.2021.01.28.03.04.50; Thu, 28 Jan 2021 03:05:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231140AbhA1LDW (ORCPT + 99 others); Thu, 28 Jan 2021 06:03:22 -0500 Received: from mga17.intel.com ([192.55.52.151]:57350 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229732AbhA1LDO (ORCPT ); Thu, 28 Jan 2021 06:03:14 -0500 IronPort-SDR: 7JjdeQuKJ6Xoq7YoTmsC3sqT5A5HXCj031UyXYWE+PvIuPJBoAdtANfilKeWeg4YJybXYvcSRh fh+E5qf2Mhtg== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="159987851" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="159987851" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:01:28 -0800 IronPort-SDR: K0tKeK4UfSNJkw/XjLaLthlwZzyhhclERSL+T8p80z6yNHYhnmq5Dvu9sc2E2mJqaMmZ/uqeLz /Yo+ak94yk0w== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="369811507" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:01:25 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 28 Jan 2021 13:01:22 +0200 Date: Thu, 28 Jan 2021 13:01:22 +0200 From: Mika Westerberg To: Lee Jones Cc: linux-kernel@vger.kernel.org, Andreas Noever , Michael Jamet , Yehezkel Bernat , linux-usb@vger.kernel.org Subject: Re: [PATCH V2 01/12] thunderbolt: dma_port: Check 'dma_port_flash_write_block()'s return value Message-ID: <20210128110122.GQ2542@lahna.fi.intel.com> References: <20210127112554.3770172-1-lee.jones@linaro.org> <20210127112554.3770172-2-lee.jones@linaro.org> <20210128085233.GE4774@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210128085233.GE4774@dell> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 08:52:33AM +0000, Lee Jones wrote: > ... and take the error path if it fails. > > Fixes the following W=1 kernel build warning(s): > > drivers/thunderbolt/dma_port.c: In function ‘dma_port_flash_write_block’: > drivers/thunderbolt/dma_port.c:331:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > Cc: Andreas Noever > Cc: Michael Jamet > Cc: Mika Westerberg > Cc: Yehezkel Bernat > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Applied, thanks!