Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp899602pxb; Thu, 28 Jan 2021 03:12:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpO19SbB7eMCf27DAlhaJnEvZOEwHDOFMoXCzRQl+aaWKExBfMceo0J65TdJKyC3CAg6ZX X-Received: by 2002:a05:6402:1e5:: with SMTP id i5mr13818629edy.86.1611832332090; Thu, 28 Jan 2021 03:12:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611832332; cv=none; d=google.com; s=arc-20160816; b=IxOWTdAiIcNQ7zkTjer9/LSr5aGWrbDXKH8+WxpxVXmNfBARRsmoGezHXwgan6eONs ZNBPPyDx0ifOFJfZH4cwG9GMRMSp01KIIdbA0E+hCJomIeI83Mya7UJ21PejF7XFIWeQ 4GAMvGrhtR0SnkSfdEeoFTpZU/b7P113eA1ENg1IhL/BtTZyANGjo5GZnZHgg7kVm/Xz GOdR+30TdJiQh7Fml1w6iKlYyDRbUNRzShlofw/uC+XRRJfsgdv2vHeKDcrPX758veay z7UT33Y8AvJaz5XpxEAZtPIG1DBgHG1FGWq2VJ7vX35fnV72d6TeoCffvhucbKyuccX0 Y4zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=WEI8adphOhW3HbTuQJ1VL0fDfVOwRKK0+yiTgMiq7AQ=; b=xttIHKm2wRAGr9eDC49JidZ/F561w9IuXYJcLTcDcaGAk93S3qb8gY3msEmVuN5zsR IrIRXNAXW8FAHH4mvhXAgi3a4auzXSY3OWiDu/qkIMshQEYeMPllAvKZTX9jUikNC7V4 QyvWPShdOs5uBCSOR+4aetC5+o7ghpZ9xAcOflpJZs0ay7vV9x4jpUBqkz/FYuD6zKcn ZoIsiZT7U4tWet4DBCLINFdrfQ2ix/bBFhDBvRRf26/AhyhjoUIus3dQ4C6mbLBWoj4V TUByoatYVOuPDAztpXUdcJOYr21yEW2SB0gWAy9wlE/V0XnMgsiSCQv/mr5IOyAs4ox2 rLzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si2620281eds.254.2021.01.28.03.11.47; Thu, 28 Jan 2021 03:12:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231210AbhA1LLL (ORCPT + 99 others); Thu, 28 Jan 2021 06:11:11 -0500 Received: from mga06.intel.com ([134.134.136.31]:58317 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231156AbhA1LK7 (ORCPT ); Thu, 28 Jan 2021 06:10:59 -0500 IronPort-SDR: DFQBtcOw5+BAGZfTiQ3jiETQcG5ISXr8zLS69GvPIUtBxm+Yaq2gG4GccZBoX0PXI7vMjtBkaq o1+i3iN5PmJQ== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="241742155" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="241742155" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:09:11 -0800 IronPort-SDR: oLTOeHJAxZveY+y0cspU8swh3mUykqlmfDB8CBvJ7nLRG4fyjW6mcagPZOo5rs3vUPhbqZP1K6 kC7ATHgNjRPw== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="473506403" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:09:07 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 28 Jan 2021 13:09:04 +0200 Date: Thu, 28 Jan 2021 13:09:04 +0200 From: Mika Westerberg To: Lee Jones Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andreas Noever , bpf@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , linux-usb@vger.kernel.org, Michael Jamet , netdev@vger.kernel.org, Yehezkel Bernat Subject: Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt Message-ID: <20210128110904.GR2542@lahna.fi.intel.com> References: <20210127112554.3770172-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127112554.3770172-1-lee.jones@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 1 small set required for Thunderbolt. Pretty good! > > Lee Jones (12): > thunderbolt: dma_port: Remove unused variable 'ret' > thunderbolt: cap: Fix kernel-doc formatting issue > thunderbolt: ctl: Demote non-conformant kernel-doc headers > thunderbolt: eeprom: Demote non-conformant kernel-doc headers to > standard comment blocks > thunderbolt: pa: Demote non-conformant kernel-doc headers > thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv' > param > thunderbolt: nhi: Demote some non-conformant kernel-doc headers > thunderbolt: tb: Kernel-doc function headers should document their > parameters > thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers > thunderbolt: icm: Fix a couple of formatting issues > thunderbolt: tunnel: Fix misspelling of 'receive_path' > thunderbolt: swit: Fix function name in the header I applied all of the changes that touch static functions. For non-static functions I will send a patch set shortly that adds the missing bits for the kernel-doc descriptions. I also fixed $subject lines of few patches ("switch:" instead of "swit:"). Please check that I got everything correct in git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next Thanks!