Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Jan 2021 14:18:56 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Jan Kara <jack@suse.cz>
Cc:     bingjingc <bingjingc@synology.com>, viro@zeniv.linux.org.uk,
        jack@suse.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, cccheng@synology.com,
        robbieko@synology.com, rdunlap@infradead.org,
        David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2 0/3] handle large user and group ID for isofs and udf
Message-ID: <20210128141856.GX308988@casper.infradead.org>
References: <1611817947-2839-1-git-send-email-bingjingc@synology.com>
 <20210128105501.GC3324@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210128105501.GC3324@quack2.suse.cz>
Precedence: bulk

On Thu, Jan 28, 2021 at 11:55:01AM +0100, Jan Kara wrote:
> On Thu 28-01-21 15:12:27, bingjingc wrote:
> > From: BingJing Chang <bingjingc@synology.com>
> > 
> > The uid/gid (unsigned int) of a domain user may be larger than INT_MAX.
> > The parse_options of isofs and udf will return 0, and mount will fail
> > with -EINVAL. These patches try to handle large user and group ID.
> > 
> > BingJing Chang (3):
> >   parser: add unsigned int parser
> >   isofs: handle large user and group ID
> >   udf: handle large user and group ID
> 
> Thanks for your patches! Just two notes:
> 
> 1) I don't think Matthew Wilcox gave you his Reviewed-by tag (at least I
> didn't see such email). Generally the rule is that the developer has to
> explicitely write in his email that you can attach his Reviewed-by tag for
> it to be valid.

Right, I didn't.

Looking at fuse, they deleted their copy of match_uint
in favour of switching to the fs_parameter_spec (commit
c30da2e981a703c6b1d49911511f7ade8dac20be) and I wonder if isofs & udf
shouldn't receive the same attention.