Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210128122311.1.I42c1001f8b0eaac973a99e1e5c2170788ee36c9c@changeid>
 <YBK/wa2AuwYJ/zTp@rocinante>
In-Reply-To: <YBK/wa2AuwYJ/zTp@rocinante>
From:   Victor Ding <victording@google.com>
Date:   Fri, 29 Jan 2021 02:07:13 +1100
Message-ID: <CANqTbdYLmbGe9GQB6QE5pdrsJYTXZo--PUEhE87-0pZCQzuYag@mail.gmail.com>
Subject: Re: [PATCH] PCI/ASPM: Disable ASPM when save/restore PCI state
To:     =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-mmc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        linux-pci@vger.kernel.org,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "Saheed O. Bolarinwa" <refactormyself@gmail.com>,
        Vidya Sagar <vidyas@nvidia.com>,
        Xiongfeng Wang <wangxiongfeng2@huawei.com>,
        Yicong Yang <yangyicong@hisilicon.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 29, 2021 at 12:44 AM Krzysztof Wilczy=C5=84ski <kw@linux.com> w=
rote:
>
> Hi Victor,
>
> Thank you for working on this!
>
> [...]
> >       i =3D pci_save_pcie_state(dev);
> >       if (i !=3D 0)
> > -             return i;
> > +             goto Exit;
> >
> >       i =3D pci_save_pcix_state(dev);
> >       if (i !=3D 0)
> > -             return i;
> > +             goto Exit;
> [...]
> > +Exit:
> > +     pcie_restore_aspm_control(dev);
> > +     return i;
> >  }
> [...]
>
> A silly thing, but the goto labels are customary lower-case.
>
> Nonetheless, this is probably something that can be corrected when
> applying, so that you don't need to unnecessarily send a new version
> (unless you will eventually following other reviews, then don't forget
> about it).
>
> Krzysztof

Thank you for reviewing. I am about to send out a V2 for a bug fix,
it will include this style change too.

Victor