Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Jan 2021 18:55:49 +0100
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCH] speakup: Make dectlk flush timeout configurable
Message-ID: <20210128175549.j5mc72mjjnh6aalk@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        speakup@linux-speakup.org
References: <20210127234444.1038813-1-samuel.thibault@ens-lyon.org>
 <YBJtqGn/ZpdFpNlg@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YBJtqGn/ZpdFpNlg@kroah.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Greg KH, le jeu. 28 janv. 2021 08:54:16 +0100, a ecrit:
> On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote:
> >  static struct kobj_attribute full_time_attribute =
> >  	__ATTR(full_time, 0644, spk_var_show, spk_var_store);
> > +static struct kobj_attribute flush_time_attribute =
> > +	__ATTR(flush_time, 0644, spk_var_show, spk_var_store);
> 
> __ATTR_RW()?

Unfortunately no because __ATTR_RW only takes the name, and uses that
for the function to be called. In our case the functions are shared.

> Also, no Documentation/ABI/ update for the new one user-visable
> attribute?  Please fix up.

Right, I'll fix it.

Samuel