Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210127233345.339910-1-shy828301@gmail.com> <20210127233345.339910-6-shy828301@gmail.com>
 <f6cfbe3c-bfca-61ee-72b4-981188456362@suse.cz>
In-Reply-To: <f6cfbe3c-bfca-61ee-72b4-981188456362@suse.cz>
From:   Yang Shi <shy828301@gmail.com>
Date:   Thu, 28 Jan 2021 14:05:25 -0800
Message-ID: <CAHbLzkp7p9vS1AScqi-w7bkUNBLATDJdjE+x1FipZXkMpGLx+A@mail.gmail.com>
Subject: Re: [v5 PATCH 05/11] mm: memcontrol: rename shrinker_map to shrinker_info
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Roman Gushchin <guro@fb.com>, Kirill Tkhai <ktkhai@virtuozzo.com>,
        Shakeel Butt <shakeelb@google.com>,
        Dave Chinner <david@fromorbit.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 28, 2021 at 9:38 AM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 1/28/21 12:33 AM, Yang Shi wrote:
> > The following patch is going to add nr_deferred into shrinker_map, the change will
> > make shrinker_map not only include map anymore, so rename it to a more general
> > name.  And this should make the patch adding nr_deferred cleaner and readable and make
> > review easier. Rename "memcg_shrinker_info" to "shrinker_info" as well.
>
> You mean rename struct memcg_shrinker_map, not "memcg_shrinker_info", right?

Actually, I mean remove "memcg_" prefix. The patch renames
memcg_shrinker_map to shrinker_info.

>
> >
> > Signed-off-by: Yang Shi <shy828301@gmail.com>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>