Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1357861pxb; Thu, 28 Jan 2021 14:32:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJybE/ygxSWysnQO2JFmSTXxlXAzRbS78H3E0DR9iTWtIfeZyc8OXig3o2kNWySr+EPAHK9x X-Received: by 2002:a05:6402:208:: with SMTP id t8mr1992642edv.189.1611873145339; Thu, 28 Jan 2021 14:32:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611873145; cv=none; d=google.com; s=arc-20160816; b=tH9kuzESPSTOqnYPnQ1lTidyX35CzeYzaXyJgknVi8Xf9Qi2xYMZRRlCT2axrybHoP HSQ3CjO2vyzPK+3hwzfExkmPi5uxo1V3ECIdz+NTTqEtktFkDU2rT3/yEnfw+7bAA8Qd zP/V+VnUREnEhAv9soatz7YZqzThG7FW0E7IZSm4vEus74iXyhhTRCEPcAGJeuxULLhe YYg3GZyilEGXtPqubjhRlsa3XJRT9H1DURH8+q0w8ARgYj7+C6j3OctdlXeOYQtrOrE1 6RWnM8T08gPfxO+REKjkbK4CG2wiMPLx0rrusimG9GmlhPzLi7VKuARHD6halCryi+oo FL0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=QCOrx8QxobunoqYIbe8/PPIA6miKMsg+Sh7m5nIYGsg=; b=lGZ0qCpRk1s8OUHOgk2Day1DxCRV7a/5KPtPLVmTM6oLuIp8Ls49wtCapCr7a9V07j YF6r5pE6B/CQ8vaFqXSydhanDZHpIw9llP1Fw1HBRiGkTRlhPcd1vuC84KQbX1c8tTp5 Nc9e1yyXB8DRH+FMQxwT50uVmwxZyetcHT/mj3VG11BkavCvBHwogJVJnvIEO/T6T3ux obQoRTfzsE6acW0knTcLABzqoqxa1qbH8QAukoXfvB8bjSIuCLBIUZmZ8Ha6QdvhT4oy jTDORiCSs+ejOQyh4N5jx4fMGHXv6GhK8Bdv/RYV+kLRShmPNxnkDsYTuiY9bUdbznJd It0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr37si3297305ejc.700.2021.01.28.14.32.00; Thu, 28 Jan 2021 14:32:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbhA1WbK (ORCPT + 99 others); Thu, 28 Jan 2021 17:31:10 -0500 Received: from hmm.wantstofly.org ([213.239.204.108]:50768 "EHLO mail.wantstofly.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229774AbhA1WbG (ORCPT ); Thu, 28 Jan 2021 17:31:06 -0500 Received: by mail.wantstofly.org (Postfix, from userid 1000) id 129A07F45D; Fri, 29 Jan 2021 00:30:20 +0200 (EET) Date: Fri, 29 Jan 2021 00:30:20 +0200 From: Lennert Buytenhek To: Jens Axboe Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [RFC PATCH] io_uring: add support for IORING_OP_GETDENTS64 Message-ID: <20210128223020.GG186627@wantstofly.org> References: <20210123114152.GA120281@wantstofly.org> <20210123232754.GA308988@casper.infradead.org> <39a9b1da-bbcc-daa0-12e9-3eb776658564@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39a9b1da-bbcc-daa0-12e9-3eb776658564@kernel.dk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 23, 2021 at 04:33:34PM -0700, Jens Axboe wrote: > >> IORING_OP_GETDENTS64 behaves like getdents64(2) and takes the same > > > > Could we drop the '64'? We don't, for example, have IOURING_OP_FADVISE64 > > even though that's the name of the syscall. > > Agreed, only case we do mimic the names are for things like > IORING_OP_OPENAT2 where it does carry meaning. For this one, it should > just be IORING_OP_GETDENTS. OK, I've made this change.