Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <955a079a3d15228ce9aeba8720dccae2dc7dfb7c.camel@perches.com>
Subject: Re: [PATCH -next] acpi: fpdt: drop errant comma in pr_info()
From:   Joe Perches <joe@perches.com>
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Len Brown <lenb@kernel.org>, linux-acpi@vger.kernel.org,
        Zhang Rui <rui.zhang@intel.com>
Date:   Thu, 28 Jan 2021 15:56:37 -0800
In-Reply-To: <20210128232528.21117-1-rdunlap@infradead.org>
References: <20210128232528.21117-1-rdunlap@infradead.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote:
> Drop a mistaken comma in the pr_info() args to prevent the
> build warning.
> 
> ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> ../include/linux/kern_levels.h:5:18: warning: too many arguments for format [-Wformat-extra-args]
> ../drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
> ????pr_info(FW_BUG, "Invalid subtable type %d found.\n",
[]
> --- linux-next-20210128.orig/drivers/acpi/acpi_fpdt.c
> +++ linux-next-20210128/drivers/acpi/acpi_fpdt.c
> @@ -252,7 +252,7 @@ void acpi_init_fpdt(void)
> ?					      subtable->type);
> ?			break;
> ?		default:
> -			pr_info(FW_BUG, "Invalid subtable type %d found.\n",
> +			pr_info(FW_BUG "Invalid subtable type %d found.\n",
> ?			       subtable->type);

Another question would be why is the pr_info when all the other
FW_BUG uses in this file are pr_err

One would think it's at least a defect of some time.
I would think it should at least be pr_notice or pr_warn

Documentation/admin-guide/kernel-parameters.txt-                        1 (KERN_ALERT)          action must be taken immediately
Documentation/admin-guide/kernel-parameters.txt-                        2 (KERN_CRIT)           critical conditions
Documentation/admin-guide/kernel-parameters.txt-                        3 (KERN_ERR)            error conditions
Documentation/admin-guide/kernel-parameters.txt-                        4 (KERN_WARNING)        warning conditions
Documentation/admin-guide/kernel-parameters.txt-                        5 (KERN_NOTICE)         normal but significant condition
Documentation/admin-guide/kernel-parameters.txt:                        6 (KERN_INFO)           informational
Documentation/admin-guide/kernel-parameters.txt-                        7 (KERN_DEBUG)          debug-level messages