Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1611800401-9790-1-git-send-email-bingjingc@synology.com>
 <CAJfpegtDbDzSCgv-D66-5dAA=pDxMGN_aMTVcNPzWNibt2smLw@mail.gmail.com> <939d2196-8468-4d93-b976-70f3d8ac83de@Mail>
In-Reply-To: <939d2196-8468-4d93-b976-70f3d8ac83de@Mail>
From:   bingjing chang <bxxxjxxg@gmail.com>
Date:   Fri, 29 Jan 2021 14:00:59 +0800
Message-ID: <CAMmgxWFMBxg47J_Zjdfm5i36m3TMf2VEzoeREGKD6VFJXcbN3A@mail.gmail.com>
Subject: Re: [PATCH 3/3] parser: add unsigned int parser
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
        Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        cccheng@synology.com, robbieko@synology.com,
        bingjingc <bingjingc@synology.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Miklos,

Thank you for your mail. Please see my message below.

bingjingc <bingjingc@synology.com> =E6=96=BC 2021=E5=B9=B41=E6=9C=8829=E6=
=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=881:50=E5=AF=AB=E9=81=93=EF=BC=9A
>
> [loop bxxxjxxg@gmail.com] in order to reply in plain-text
> Miklos Szeredi <miklos@szeredi.hu> =E6=96=BC 2021-01-28 16:37 =E5=AF=AB=
=E9=81=93=EF=BC=9A
>
> On Thu, Jan 28, 2021 at 3:21 AM bingjingc <bingjingc@synology.com> wrote:
> >
> > From: BingJing Chang <bingjingc@synology.com>
> >
> > Will be used by fs parsing options
> >
> > Reviewed-by: Robbie Ko<robbieko@synology.com>
> > Reviewed-by: Chung-Chiang Cheng <cccheng@synology.com>
> > Signed-off-by: BingJing Chang <bingjingc@synology.com>
> > ---
> >  fs/isofs/inode.c       | 16 ++--------------
> >  fs/udf/super.c         | 16 ++--------------
> >  include/linux/parser.h |  1 +
> >  lib/parser.c           | 22 ++++++++++++++++++++++
> >  4 files changed, 27 insertions(+), 28 deletions(-)
> >
> > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> > index 342ac19..21edc42 100644
> > --- a/fs/isofs/inode.c
> > +++ b/fs/isofs/inode.c
> > @@ -335,18 +335,6 @@ static const match_table_t tokens =3D {
> >         {Opt_err, NULL}
> >  };
> >
> > -static int isofs_match_uint(substring_t *s, unsigned int *res)
> > -{
> > -       int err =3D -ENOMEM;
> > -       char *buf =3D match_strdup(s);
> > -
> > -       if (buf) {
> > -               err =3D kstrtouint(buf, 10, res);
> > -               kfree(buf);
> > -       }
> > -       return err;
> > -}
>
> I don't see how adding this function and removing it in the same
> series makes any sense.

That's true. Simple and clear is better.
I used to think that the acceptance of patch can be 3/3 or 2/3.
And I was not sure are there needs for making match_uint
as shared lib. So I made the first patch.

I simplify them. Please see the third patch, thanks!

>
> Why not make this the first patch in the series, simplifying everything?
>
> And while at it the referenced fuse implementation can also be
> converted (as a separate patch).
>
> Thanks,
> Miklos

Thanks,
BingJing