Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1596994pxb; Thu, 28 Jan 2021 23:20:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpGG6X37s6SjY5rTWlzG7NrPUra0auyJHjb8qq5y4gOj8kvH3TyvvKMFuMFHeYkt8I4riK X-Received: by 2002:a17:906:7948:: with SMTP id l8mr3276423ejo.550.1611904805791; Thu, 28 Jan 2021 23:20:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611904805; cv=none; d=google.com; s=arc-20160816; b=aOxvd4SpTQZMYGaoMCGivpYkDVsL7QonE3B7OJhzCoTvfGyXDFUfnfG2A/uxVhBc1E oK9CWGW6luiVrk8dLuf6Yc3PiEV8ie+sqeoigoWj7CjZk9Dwpk4MPuG845TI4BK5Duzh kwL0tqurXdraXLTTFom7BE03jcJ5UbUxdKAgHSyuXaSvhPGI+YeojbG6J8eHWgAYk2sW m5bU7oG02hfUpipAFz0/5grpA8Cr5hwZiTc/3nchxKSmEkFQVizQTuLMSUMbN+ZnUBdz p5okubt3/sRNOpWL8QlUZG7MHK2X4Cgyl8aWfBhTbaQF5JsxglN5LzjRKv5atW0oNrS/ SduQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=nAnTETMHcfweHl7T4+bq1hybnR4BA4pB1t2JYrikVAk=; b=YiXZp9bIkMNGTme6Xql567yjDT6hPaRedxyjhR3Nt4HmCjuskHAW9Rlp10+twM8o+l OvrpJxkqhqcHuOOFPyj7eAJiU3K+PBLAO47HbYlkPxYMjjz94wkntVLk/hwV8Tf0IMfC 6inSpXTJ2g/RAauYJMRSmxG0TxBpquQ0vcwZ1arpJLKYHmptdYR6qcMXVNSVkAbgmu6y Vx4utP5eetahat4oVAAAzIWCTJrOpxvoQigyI0WaAHVj7/qoow3SpEXP62gMHdwoZNq2 IEASWPeas65y4QSEK4xWG/QethUa3DHO6z+OtwqAQaxTd1xlT/CXSyDf+U8/1ArI+Vt0 iDcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=KS95H98d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j19si4936858edw.550.2021.01.28.23.19.41; Thu, 28 Jan 2021 23:20:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=KS95H98d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbhA2HSK (ORCPT + 99 others); Fri, 29 Jan 2021 02:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhA2HSB (ORCPT ); Fri, 29 Jan 2021 02:18:01 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4014C061574 for ; Thu, 28 Jan 2021 23:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=nAnTETMHcfweHl7T4+bq1hybnR4BA4pB1t2JYrikVAk=; b=KS95H98dWPeHViBs1Z6WwzGCFO CTZBeyqLXhKw1cPWie38D9LoqDVH1DFrQ22pXi1yOwt5U3R8Qrgy7lIX+AjJ93EzMjFiZxsdH9Cgx rfP/mxCOo+v0Uq5lSknEiLvmdDtql2WKeEucP/PPodOXQKXxGIwAW2NXzjmVnSrFFvnqA3gwQ7fmz gG0AUjM9hVSsgPRB2FuSWekhC886QUDJyw7pJvJmD9neAg/IkCWox3q5jbx6mOQr5L8JXFYfGAycJ ru70Yq8twQsxnTiiZWppvpfnVQAKqYJer+htJiWBBZYsyHglvJ6UxZ0msCtKXnWV6Y6HKsFzr+K6f VGp/Q5TQ==; Received: from [2601:1c0:6280:3f0::7650] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5O1s-00014O-Fd; Fri, 29 Jan 2021 07:17:16 +0000 Subject: Re: [PATCH] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set To: Scott Branden , Arnd Bergmann , Greg Kroah-Hartman Cc: Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Olof Johansson , Desmond Yan References: <20210129060443.14864-1-scott.branden@broadcom.com> From: Randy Dunlap Message-ID: <90a4fb55-3ecc-cdcd-2884-1f65062d139c@infradead.org> Date: Thu, 28 Jan 2021 23:17:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210129060443.14864-1-scott.branden@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/28/21 10:04 PM, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_TTY is set. > > Reported-by: Randy Dunlap > Signed-off-by: Scott Branden > --- > drivers/misc/bcm-vk/Makefile | 4 ++-- > drivers/misc/bcm-vk/bcm_vk_dev.c | 13 +++++++++++++ > 2 files changed, 15 insertions(+), 2 deletions(-) Acked-by: Randy Dunlap # build-tested Thanks. -- ~Randy