Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1925973pxb; Fri, 29 Jan 2021 08:33:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaHBkw30ZgtQHOlFsGO5j9tlza96gBW2hRVNv6NOBQawsOjbh5ob0//o4TUapfFWBylCw1 X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr5194552ejc.434.1611938018030; Fri, 29 Jan 2021 08:33:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611938018; cv=none; d=google.com; s=arc-20160816; b=pco0Q8bbUi/f4U1OQRuGjTnG5/63cVin7onMVHRk1x3dmqjVWbiKU5Gsze/IZogbl7 GPxy61sS/31LeQB7fWTMcJ0f/uGJAfO80oAKFHUEnjBvHU9kWYlUspEHEfEVQ5CA5/c6 I1o3R2zp8vqHSNDwAB8qfRZu1NgEpv5vwjgBj8Qd/vzOuRcBBxD02R0Ry80MOhnfpa2u SzT7ZRO4F1i42vdHN53LRTrDCu4A+JWp+19OkvCx9TF1tOMagnYx6JyDqxzQyNsVOWt3 A6M09U9hVZyqLYNPZ3BMQocN5lUzxZYKHMw9c5UacrBBwE5OI3WCxvR0v2k9jRsgMPGX Bqag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=8HRlUymAfGaL34fIj1DXJ5Yvrh5IYO00jyj0MFqoNsA=; b=s7GA7Hnb7YcK9+Ykw/g3Bk/Zq392mRklfk5Kh5CF/XD3+l5bY3VFzRYTlPT7iGvLxZ Q/qQuPpRrwhk+O+gYygcQ/SWbHs3GcVYPg6/bzpflljIOiQZ2KXEQJ+87IEy1pSAo6Sa DuSMsqWjol/rARWKvPlhq6MVuXQBz9lUcKx3zA8EUfXGryI/llKmIx91mfLW4Qd/jPyI nMn8XgiKzPIuv6blrk13V/ymVCThL5ffEVonyrWUYeEzKWsNzyVAVZspYqFQ7NA5pHtI YpZ+o0yDVeaHzC60h0TOxPMvTtNWjOy0koai4Faq5Y/NJ212VmNkVuOUfWqkaHEab288 RfEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s20si4970169eji.61.2021.01.29.08.32.30; Fri, 29 Jan 2021 08:33:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231159AbhA2QaQ (ORCPT + 99 others); Fri, 29 Jan 2021 11:30:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:55062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231151AbhA2QaO (ORCPT ); Fri, 29 Jan 2021 11:30:14 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82F3264E02; Fri, 29 Jan 2021 16:29:33 +0000 (UTC) Date: Fri, 29 Jan 2021 11:29:32 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Wang ShaoBo , , , , , , , Subject: Re: [PATCH v2] kretprobe: avoid re-registration of the same kretprobe earlier Message-ID: <20210129112932.41e56f4f@gandalf.local.home> In-Reply-To: <20210129222947.f873666f4e6110c62b7439f1@kernel.org> References: <20210128124427.2031088-1-bobo.shaobowang@huawei.com> <20210128130621.41d99638@gandalf.local.home> <20210129222947.f873666f4e6110c62b7439f1@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2021 22:29:47 +0900 Masami Hiramatsu wrote: > I'll send a patch over this to replace those check with WARN_ON() since > it's a software bug and should be fixed. Please use WARN_ON_ONCE() Thanks! -- Steve