Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH iproute-next v2] devlink: add support for port params
 get/set
To:     Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        netdev@vger.kernel.org
Cc:     jiri@nvidia.com, davem@davemloft.net, linux-kernel@vger.kernel.org,
        kuba@kernel.org
References: <20210125134838.22439-1-oleksandr.mazur@plvision.eu>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <5a96437d-a1d4-8535-e9c1-fd29b1eb8166@gmail.com>
Date:   Fri, 29 Jan 2021 09:22:48 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210125134838.22439-1-oleksandr.mazur@plvision.eu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/25/21 6:48 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters getting/setting.
> Add bash completion for port param.
> Add man description for port param.
> 

Add example commands here - both set and show. Include a json version of
the show.

> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
> ---
> V2:
>     1) Add bash completion for port param;
>     2) Add man decsription / examples for port param;
> 
>  bash-completion/devlink |  55 ++++++++
>  devlink/devlink.c       | 275 +++++++++++++++++++++++++++++++++++++++-
>  man/man8/devlink-port.8 |  65 ++++++++++
>  3 files changed, 389 insertions(+), 6 deletions(-)
> 

> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index a2e06644..0fc1d4f0 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -2706,7 +2706,8 @@ static void pr_out_param_value(struct dl *dl, const char *nla_name,
>  	}
>  }
>  
> -static void pr_out_param(struct dl *dl, struct nlattr **tb, bool array)
> +static void pr_out_param(struct dl *dl, struct nlattr **tb, bool array,
> +			 bool is_port_param)
>  {
>  	struct nlattr *nla_param[DEVLINK_ATTR_MAX + 1] = {};
>  	struct nlattr *param_value_attr;
> @@ -2714,6 +2715,7 @@ static void pr_out_param(struct dl *dl, struct nlattr **tb, bool array)
>  	int nla_type;
>  	int err;
>  
> +

stray newline here