Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 29 Jan 2021 17:17:59 +0100
Message-ID: <s5hft2jlnt4.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Michael Catanzaro <mcatanzaro@redhat.com>
Cc:     "N, Harshapriya" <harshapriya.n@intel.com>,
        alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-kernel@vger.kernel.org,
        kai.vehmanen@intel.com, stable@vger.kernel.org
Subject: Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM"
 broke
 my
 laptop's internal audio
In-Reply-To: <8CEPNQ.GAG87LR8RI871@redhat.com>
References: <EM1ONQ.OL5CFJTBEBBW@redhat.com>
        <BY5PR11MB430713319F12454CF71A1E73FDB99@BY5PR11MB4307.namprd11.prod.outlook.com>
        <U3BPNQ.P8Q6LYEGXHB5@redhat.com>
        <s5hsg6jlr4q.wl-tiwai@suse.de>
        <9ACPNQ.AF32G3OJNPHA3@redhat.com>
        <IECPNQ.0TZXZXWOZX8L2@redhat.com>
        <8CEPNQ.GAG87LR8RI871@redhat.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 29 Jan 2021 17:12:08 +0100,
Michael Catanzaro wrote:
> 
> On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro
> <mcatanzaro@redhat.com> wrote:
> > OK, I found "ALSA: hda/via: Apply the workaround generically for
> > Clevo machines" which was just merged yesterday. So I will test
> > again to find out.
> 
> Hi Takashi, hi Harsha,
> 
> I can confirm that the problem is fixed by this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4961167bf7482944ca09a6f71263b9e47f949851

Thanks, good to hear.

Then I think we can drop the entry from power_save_denylist in
hda_intel.c.  Could you try that it still works with the patch below?


thanks,

Takashi

--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = {
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
-	SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
-	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0),
 	/* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
 	/* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */