Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1978602pxb;
        Fri, 29 Jan 2021 09:47:13 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzmvW7Z3a1wg1DDDFRmZlWwU9eO23TXDBUiRzCyKJZtKXNmGf3YzdDPjSko9PoJz9JEX8i1
X-Received: by 2002:a17:906:2f09:: with SMTP id v9mr5690962eji.151.1611942432958;
        Fri, 29 Jan 2021 09:47:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1611942432; cv=none;
        d=google.com; s=arc-20160816;
        b=GZ+Tn+A6ZkF65BGyUliufLr9zGhJfElrDgbzOUqmN7Sk3gv5QF3RXnOa5ji62oQo2U
         /DdMmiL6FCkkLd0+JFu3dN+b3u2cNZbIpQAmBh1Ybg5gzRSA1rLKhQRvbOag3BGa5t+B
         xZ2z7OW7k5PAfng6fzSqV4NzE9q1hh/M9MFsw1SX3Rtf8s2z3JnQVFWpsKKjQu5cFwcG
         BMI4CFmHk9OdLNsQypCbZaD3ypz8I93vlte+SArZJ77MEN0jhSrIZuocYT70W6KZvhIC
         12q9uLBafabPub7NuZVwGGwTgoDLHLwJvcZE2xQncxZB8KGTwu5gTigowQmFCmeSvD6v
         +2Yg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:message-id:date:content-id:mime-version:subject
         :cc:to:references:in-reply-to:from:organization:dkim-signature;
        bh=f0G6YrULWY0Hpt3rLR1Rw+mBqOBEBcyFzEyoDQIunkM=;
        b=h9XGHjmIbmUHYITDnge3XjFx9OXlf3x97Ddhee6XCN5XySLKp8dvSTIvnim+Mz8N9e
         rR9JDZTKGCVMIvne4pvo5pSqH7VAGgntx2NKaOSyAY2KYmx4mrU53Mj93sg4eOz/ebie
         JW6q9VZResaWIUY+yEPdnZK/r7CX3WNt4svplsMIodKEkT+3BDva3VCtNopeffZWoT62
         WQGlrX61bEBipwDCaP1DSsw8GvHGSZx3328wutk2PNG/ZnvNbWjyBKTRGTjCdZSZYy9B
         yp7C/GcvjkUdxjOBSXbCfrp/AWzyCMgUIWvXm0Pr2p8Jh6hhQ0aLMeJmokJogNeaQNCK
         fXqw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JtyM4YHJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p1si6140857eds.205.2021.01.29.09.46.47;
        Fri, 29 Jan 2021 09:47:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JtyM4YHJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232464AbhA2RpK (ORCPT <rfc822;lizhiguo.at@gmail.com>
        + 99 others); Fri, 29 Jan 2021 12:45:10 -0500
Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53009 "EHLO
        us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S231940AbhA2RnC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 29 Jan 2021 12:43:02 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1611942094;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=f0G6YrULWY0Hpt3rLR1Rw+mBqOBEBcyFzEyoDQIunkM=;
        b=JtyM4YHJr8GY8G7NSchJG04pySBkomM1EUohNH5GrUHgfNychcdwHofClIK4m4pq4xdsCz
        ZaslRi9JH+0I94VdnM1zdge3Z27rmfy9+DgjlZEzdK8EU+E+HZOjxpMhixImSfCeLkR+TK
        rcS/l04JhxSbGVw19XlAEEXRjeWux/Q=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-158-2lwRzLMEPXWK5VVa-IqQcA-1; Fri, 29 Jan 2021 12:41:32 -0500
X-MC-Unique: 2lwRzLMEPXWK5VVa-IqQcA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF877806693;
        Fri, 29 Jan 2021 17:41:30 +0000 (UTC)
Received: from warthog.procyon.org.uk (ovpn-115-23.rdu2.redhat.com [10.10.115.23])
        by smtp.corp.redhat.com (Postfix) with ESMTP id 8AD445B694;
        Fri, 29 Jan 2021 17:41:29 +0000 (UTC)
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <076fad09-b59e-cb6d-6303-adf5964e13c7@novek.ru>
References: <076fad09-b59e-cb6d-6303-adf5964e13c7@novek.ru> <161193864000.3781058.7593105791689441003.stgit@warthog.procyon.org.uk>
To:     Vadim Fedorenko <vfedorenko@novek.ru>
Cc:     dhowells@redhat.com,
        syzbot+df400f2f24a1677cd7e0@syzkaller.appspotmail.com,
        netdev@vger.kernel.org, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3834975.1611942088.1@warthog.procyon.org.uk>
Date:   Fri, 29 Jan 2021 17:41:28 +0000
Message-ID: <3834976.1611942088@warthog.procyon.org.uk>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Vadim Fedorenko <vfedorenko@novek.ru> wrote:

> You missed the call to dst_release(sk->sk_rx_dst) in
> rxrpc_sock_destructor. Without it we are still leaking the dst.

Hmmm...  I no longer get the messages appearing with this patch.  I'll have
another look.

David