Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210128233629.4164-1-etremblay@distech-controls.com>
 <20210128233629.4164-4-etremblay@distech-controls.com> <YBPwlmxNfrxSLK0B@smile.fi.intel.com>
 <22d98a58-724c-a563-d55c-7c18b5271ec7@distech-controls.com>
In-Reply-To: <22d98a58-724c-a563-d55c-7c18b5271ec7@distech-controls.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 29 Jan 2021 20:42:51 +0200
Message-ID: <CAHp75VdN80xTCxH19OLq1D3PqgfbV+TEs=aTHP62ScsG+aZ72g@mail.gmail.com>
Subject: Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64
To:     Eric Tremblay <etremblay@distech-controls.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        "Matwey V. Kornilov" <matwey.kornilov@gmail.com>,
        Giulio Benetti <giulio.benetti@micronovasrl.com>,
        Lukas Wunner <lukas@wunner.de>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        christoph.muellner@theobroma-systems.com,
        =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 29, 2021 at 8:07 PM Eric Tremblay
<etremblay@distech-controls.com> wrote:
> On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:

...

> Considering the use of the reversed capability UART_CAP_NOTEMT should I set
> the flag directly in uart_config like:
>
> [PORT_16550A_FSL64] = {
>                 .name           = "16550A_FSL64",
>                 .fifo_size      = 64,
>                 .tx_loadsz      = 63,
>                 .fcr            = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
>                                   UART_FCR7_64BYTE,
>                 .flags          = UART_CAP_FIFO | UART_CAP_NOTEMT,
>         },

This looks much better!

-- 
With Best Regards,
Andy Shevchenko