Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <63f00f514f1e912b8fb1d0c183e9167b60b3a5dc.camel@gmail.com>
Subject: Re: [PATCH V2] scsi: ufs: Add UFS3.0 in ufs HCI version check
From:   Bean Huo <huobean@gmail.com>
To:     Nitin Rawat <nitirawa@codeaurora.org>, cang@codeaurora.org,
        asutoshd@codeaurora.org, stummala@codeaurora.org,
        vbadigan@codeaurora.org, alim.akhtar@samsung.com,
        avri.altman@wdc.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, stanley.chu@mediatek.com,
        beanhuo@micron.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Fri, 29 Jan 2021 20:25:38 +0100
In-Reply-To: <1611058021-18611-1-git-send-email-nitirawa@codeaurora.org>
References: <1611058021-18611-1-git-send-email-nitirawa@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-01-19 at 17:37 +0530, Nitin Rawat wrote:
> As per JESD223D UFS HCI v3.0 spec, HCI version 3.0
> is also supported. Hence Adding UFS3.0 in UFS HCI
> version check to avoid logging of the error message.
> 
> Signed-off-by: Nitin Rawat <nitirawa@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 5 +++--
>  drivers/scsi/ufs/ufshci.h | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 82ad317..54ca765 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -9255,8 +9255,9 @@ int ufshcd_init(struct ufs_hba *hba, void
> __iomem *mmio_base, unsigned int irq)
>         if ((hba->ufs_version != UFSHCI_VERSION_10) &&
>             (hba->ufs_version != UFSHCI_VERSION_11) &&
>             (hba->ufs_version != UFSHCI_VERSION_20) &&
> -           (hba->ufs_version != UFSHCI_VERSION_21))
> -               dev_err(hba->dev, "invalid UFS version 0x%x\n",
> +           (hba->ufs_version != UFSHCI_VERSION_21) &&
> +           (hba->ufs_version != UFSHCI_VERSION_30))
> +               dev_err(hba->dev, "invalid UFS HCI version 0x%x\n",
>                         hba->ufs_version);

Hi Nitin
Except HCI 1.0 / 1.1 / 2.0 / 2.1 / 3.0, do you have the other UFS HCI
version? if no, current driver supports all of them,  instead of
scaling these check, and avoid logging of the error message, I suggest 
you can directly delete these redundant checkup.

If there is a weird HCI version that not supported by the current
driver, you can only add an unsupported checkup list. thus, you don't
need to scale this useless checkup.

Bean