Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on
 udp tunnel
To:     David Howells <dhowells@redhat.com>
Cc:     syzbot+df400f2f24a1677cd7e0@syzkaller.appspotmail.com,
        netdev@vger.kernel.org, linux-afs@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <076fad09-b59e-cb6d-6303-adf5964e13c7@novek.ru>
 <161193864000.3781058.7593105791689441003.stgit@warthog.procyon.org.uk>
 <3834976.1611942088@warthog.procyon.org.uk>
From:   Vadim Fedorenko <vfedorenko@novek.ru>
Message-ID: <f8c2e8be-7a5a-83a0-fc86-2bdd1095c33d@novek.ru>
Date:   Fri, 29 Jan 2021 19:53:42 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3834976.1611942088@warthog.procyon.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29.01.2021 17:41, David Howells wrote:
> Vadim Fedorenko <vfedorenko@novek.ru> wrote:
> 
>> You missed the call to dst_release(sk->sk_rx_dst) in
>> rxrpc_sock_destructor. Without it we are still leaking the dst.
> 
> Hmmm...  I no longer get the messages appearing with this patch.  I'll have
> another look.

Sorry, my bad. rxrpc_sock_destructor destroys AF_RXRPC sockets, which are 
totally different from the UDP kernel socket used as a transport and which are 
destroyed as usual UDP sockets.

Ack-by: Vadim Fedorenko <vfedorenko@novek.ru>