Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2099688pxb; Fri, 29 Jan 2021 13:12:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8M18ihSAoWSdxox+oM2vIQNZIaeabNGSHU9aLTMQUcf8+QjC55D3Fd5RLWY9gNN/se0g1 X-Received: by 2002:a05:6402:1655:: with SMTP id s21mr7202927edx.360.1611954759397; Fri, 29 Jan 2021 13:12:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611954759; cv=none; d=google.com; s=arc-20160816; b=cxEbDhAq3bdoDdJI5L73wNzHSOtflwNW58DBKIrJnheu0+89XWYGYwa3HED+KmlXmG nBxw34nlqiz09sajw6gsSuBTRX6JxnEibjWODojVYGAv59peRFSKD/lFyxMK6U+ouCbQ zqzbEK+1DH/oZ8u/L84gFHIZUWidJGgC5LiEMtdXTUdF/RVL4ZjLYOZomG2d19q7x1Va a4iDNwFW05TghUepw9bsuoev2hUdI9EpMZMTneh2lqOWwB4ky4uSU6+wbirMj8QtuA0g /fGoAXPL2I9mPoqprnghiQ0evdcD+eJ3T8MwQDsWwpS/fU1Wuiy69lFCzRtmUIONfdxe PV/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=9YzMSqkbMdwyLW7bnY85Ps0hr1nUm8VqGkvZHY3ppnQ=; b=vhSjAXbMefQnCaZCPlN2Tz5YcPDpt4vMwYeUQOS+GYeSACObj7BLIgVmwLsW3jYZlq h5blGTjjI0SeKe/N7Wdchg3pd4ZsvGe4xP4+NEbCJ2h2LEpz5cBeu+tZHFKJSBKhn0Ea YwNArVNtQKV3fT2WvpNSmM+KxPGOTLlzPh5STIgggvfhGPPyznk7yF370+T6CSbcgS2L 5Aw8Yq5biGY3U6vMFnua2bfJMrNtIlTrR/l3iZeextU8Be//zpzscQU5jrt11EgVCUYp 3gI3FfVwgiRg66WBfFlNTSrhQka/c7klZgJwED0jQ8WbCQPqbBAs577Q9deUMdE4DbqQ utVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=q0JRnU5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si5533633ejr.748.2021.01.29.13.12.14; Fri, 29 Jan 2021 13:12:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=q0JRnU5D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233102AbhA2VJS (ORCPT + 99 others); Fri, 29 Jan 2021 16:09:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232781AbhA2VJQ (ORCPT ); Fri, 29 Jan 2021 16:09:16 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E4BC061573 for ; Fri, 29 Jan 2021 13:08:36 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id q2so5999025plk.4 for ; Fri, 29 Jan 2021 13:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9YzMSqkbMdwyLW7bnY85Ps0hr1nUm8VqGkvZHY3ppnQ=; b=q0JRnU5DeZ0mt9nszXcnrwygTcitoW7AmCRbNY2bSZMjpRA8pdAP2Mns339+kra0pz A21qssoGxuCmCuu1lvk0VLLBvkLq7Y3J2cxCN4Wn7hQVuvLEKGuBzvHG7Srx3vb2y15I Vbb9epAAG+tO8XuZVOl3ZjA/NgiuXta29KgLbW1szvIlJPGPGlzcl2KmXEvqAF/zd2ec gXmlk6vGjq51CXFugGGIsnPf2ctFE4M5KagLdMR5OznJBwDZqTFbyUp6TN4JqRsB7vRX 5fe1wW+E5TA27gk4n/AZOF3JKfrRGD2tZjLCqCfnr/p9fIQWVizINbbQjUYrpJLH892K N+wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9YzMSqkbMdwyLW7bnY85Ps0hr1nUm8VqGkvZHY3ppnQ=; b=d0PrdCbCgB1DafaMY/uDL4Ph2BikpG5vX3Ntc+bV2ESZ4uHN5m2lgnWi2U1EUNEIi7 19GHsqT+3G3rlKu4QWzFdzgwtw89ulIN2OTorGlOv5tnBJoAml48zU86s/qaKNU5VHnF qtV0rKBjsG1w5cmdSD0VOAnURNNa0lcAXgrj634op2G6gmxpHvBmTiwsiBmQcMraw1eD 1pybgszxa3mBvlQkT1zK9gLNinknvYULTsMiD5G7gC5Akuh1ZZ5kQTpfJcAP/YlKzVv6 24N57hON80oPT+IptLFWegSz5sSSwg6KGbJi7v67QomGCsFkESYfkXd4Hwffjfo/daEl jAiw== X-Gm-Message-State: AOAM531nvdij9WZnEyd3Ms+kBcIAHSVFM4kFaz1lmpO1aQxZolR17e/h LWzda9BkK9A5F+UvUR1sIvPc3g== X-Received: by 2002:a17:90b:e86:: with SMTP id fv6mr6131803pjb.118.1611954516017; Fri, 29 Jan 2021 13:08:36 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id i7sm9952148pfc.50.2021.01.29.13.08.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jan 2021 13:08:35 -0800 (PST) Subject: Re: [PATCH RESEND] ata: ahci_brcm: Add back regulators management To: Florian Fainelli , linux-kernel@vger.kernel.org, hdegoede@redhat.com Cc: "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" References: <20210129182846.1944699-1-f.fainelli@gmail.com> From: Jens Axboe Message-ID: <12b9d77c-784d-52c6-eece-e67db3f4f52c@kernel.dk> Date: Fri, 29 Jan 2021 14:08:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210129182846.1944699-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/21 11:28 AM, Florian Fainelli wrote: > While reworking the resources management and departing from using > ahci_platform_enable_resources() which did not allow a proper step > separation like we need, we unfortunately lost the ability to control > AHCI regulators. This broke some Broadcom STB systems that do expect > regulators to be turned on to link up with attached hard drives. Applied, thanks. -- Jens Axboe