Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2142849pxb; Fri, 29 Jan 2021 14:35:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJyxkd7BV26KX0K8WH0tAue/olQCxtv6adkyOZsNY1EarbcplgPY3M3p/Cq0oUBpOOqMrkmr X-Received: by 2002:aa7:d386:: with SMTP id x6mr7849108edq.194.1611959740970; Fri, 29 Jan 2021 14:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611959740; cv=none; d=google.com; s=arc-20160816; b=yKB7yyJLk1rcdQirbBBrU+1d7IQlK/qn6+KVVqG34yZYymy/AFY34/f8yi0QnbATIv KyIUKl31ZNyD5OZemNRPTdsch7sKRoEM/ApFhvuyx7VSXq4f1ZHMLOPw21LConW0Up03 Pt2UovTH6xiNX/+E1vDDoQOeCTXn9GMjSUZ6Pc75YoZC53C0F0iH130MLOIm0rnqFXjA qmA6FEuxEoNyIm0XNmDsNqM8c4ewBSFJhrzBTrqUby1PsNcKrRroVKKMNT03AbDvR7RT xXRxH+wznplmaoEJ8GeK3HxgFF3xvDc6UXmzdx6futLR22MROboiVr8A2h/Yfk48Z26w nujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bkQ5Fz9RLzxxbo8DDzhzWAT6RjyUwzhlJneTB6y567o=; b=uXDBXjqV29SGTanZ+nFsevjGtXvhiNhd3gtyN2wd4d7YMQ4EPRk0ytdlv9UGk+mW3/ VI+IBH7GSXD1HolVtwvYRiHK26i8OE2Rk80usrUJGSmh3T6M/N+F45Axwz+mHaD4dAT3 RSHMv2jW62aj+eBIB/x7tLlMagnyUwUn3ClY4bJDBAU9A4B/cyOI2UUtPBkRmumT4CnZ I1rJOndFpE1Wt3eTpKf5t0984rgQHGAB4FDH705JiJUOJlSeZ6YN9DrFoRH9IKV2hKJe 0B19rMoy6uR2IvaVZawEyRv6wjRQjuOPgwm34Ccc3nkagOiQb1MrwJCsKpCryCBGqBEX 9rjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W+QCWlIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy24si6259433edb.480.2021.01.29.14.35.16; Fri, 29 Jan 2021 14:35:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W+QCWlIs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233508AbhA2WdG (ORCPT + 99 others); Fri, 29 Jan 2021 17:33:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44522 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbhA2WdC (ORCPT ); Fri, 29 Jan 2021 17:33:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611959494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bkQ5Fz9RLzxxbo8DDzhzWAT6RjyUwzhlJneTB6y567o=; b=W+QCWlIslc3WFz8xBY5V0NDD88XMXMMYIaACXU1X6Lv/SY244nx4qCCpzxijnWRoLuA40o BNJMyfetiqAVTvQy09G2Cjr+JmYfdj6JAGWuAsoWTmZF9REefuFy++v1RJ/ERvrAtMzP16 Ib373xKB/lLaWStCL3mPSVFKjpE3oa0= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-keLhSUVCMxa3CCMw-39Tuw-1; Fri, 29 Jan 2021 17:31:33 -0500 X-MC-Unique: keLhSUVCMxa3CCMw-39Tuw-1 Received: by mail-qt1-f198.google.com with SMTP id d1so7085714qtp.11 for ; Fri, 29 Jan 2021 14:31:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bkQ5Fz9RLzxxbo8DDzhzWAT6RjyUwzhlJneTB6y567o=; b=U1GB/4lZICk0uq5fJ6F+XOYV9Q6Fuvc+sNwILI0A+AG33iClYG9jA2uUGWRxewpH7z P4+T3WLoeKpfjd0Kvi5w2NCDs4OU5DtFe+mZiBuziYVO8RBiB1usyQtTqcUTGVyE4lVH tdkDT898MpssmzxXyB9Z7RfiMkxMrE8AdzAuYj+dXKcjSUpbtimJC342XbtAGNqqBVXO WJb5rPTC+H74fXxWarHGwWAYRzvQnKvHj8pVpqOxshNWCjahU0D44sRqHDEKIfdlEH/l 9Z8XrPdB5LiFUS+qWUU8yirUxa64fO+Lh4pPO3DGe/vr6GLcuGdWNuJoye9kSd25Kggq ojgA== X-Gm-Message-State: AOAM533HXvVg1vrIzyUjV4Qbw2ecRkWEK559GeCQ42zgz/IEq/JE5Uuu 5ayDiEeqo+UWN/SeX5yOa0BsW1X4R1hCl1nVQlzQ0EOof6AS8aWCauP1N0WVlqQaoALGugWZQUw 6/4nixir2WhFAVe/8ciFn14dW X-Received: by 2002:a05:622a:216:: with SMTP id b22mr6119531qtx.163.1611959492706; Fri, 29 Jan 2021 14:31:32 -0800 (PST) X-Received: by 2002:a05:622a:216:: with SMTP id b22mr6119516qtx.163.1611959492528; Fri, 29 Jan 2021 14:31:32 -0800 (PST) Received: from xz-x1 ([142.126.83.202]) by smtp.gmail.com with ESMTPSA id p188sm6231399qkf.40.2021.01.29.14.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 14:31:31 -0800 (PST) Date: Fri, 29 Jan 2021 17:31:29 -0500 From: Peter Xu To: Axel Rasmussen Cc: LKML , Linux MM , Mike Rapoport , Mike Kravetz , Jerome Glisse , "Kirill A . Shutemov" , Hugh Dickins , Matthew Wilcox , Andrew Morton , Andrea Arcangeli , Nadav Amit Subject: Re: [PATCH RFC 21/30] hugetlb: Pass vma into huge_pte_alloc() Message-ID: <20210129223129.GB260413@xz-x1> References: <20210115170907.24498-1-peterx@redhat.com> <20210115170907.24498-22-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 02:59:13PM -0800, Axel Rasmussen wrote: > > +pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma, > > This was pointed out to me just after I sent v3 of my series today > (which includes this patch): > > Typo, s/structt/struct/. Thanks Axel - fixed here too. It's strange why it didn't complain. Re the minor fault series, I thought it would be good to have some comment from Andrea/Mike or others, but in all cases I'll read your v3 next week. (A small heads-up: you'd better use v3.1 next time for that single patch, so that just in case there will be a complete v4 series then that patch won't collapse with it) -- Peter Xu