Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: bWyRo2SOqlmdvVNRaWOFJd0jOYAWKR/5UgMJyhWaEWbv1Rrdwv/sp14cJN+RZuCCn6CpdKIP3t
 l6BizDPZORkw==
IronPort-SDR: oWkJrKyr8/3tj4MBmSXFZ09RJd1uiVPCtGphBHHP6lK7WrTAe42T199htzu1bomke11bMLkDaa
 BwZn8fYtORpQ==
Date:   Fri, 29 Jan 2021 14:55:29 -0800
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Aili Yao <yaoaili@kingsoft.com>
Cc:     x86@kernel.org, naoya.horiguchi@nec.com,
        linux-kernel@vger.kernel.org, yangfeng1@kingsoft.com
Subject: Re: [PATCH] x86/fault: Send SIGBUS to user process always for
 hwpoison page access.
Message-ID: <20210129225529.GA42172@agluck-desk2.amr.corp.intel.com>
References: <20210128194326.71895e92.yaoaili@kingsoft.com>
 <20210128174352.GA33283@agluck-desk2.amr.corp.intel.com>
 <20210129113334.344377ac.yaoaili@kingsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210129113334.344377ac.yaoaili@kingsoft.com>
Precedence: bulk

Thanks for the explanation and test code. I think I see better what
is going on here.

[I took your idea for using madvise(...MADV_HWPOISON) and added a new "-S"
option to my einj_mem_uc test program to use madvise instead of ACPI/EINJ
for injections. Update pushed here:
	git://git.kernel.org/pub/scm/linux/kernel/git/aegl/ras-tools.git ]

There have been some small changes to arch/x86/mm/fault.c since you wrote
the patch.  Can you rebase to v5.11-rc5?

Also maybe this might be a case to use IS_ENABLED() instead of #ifdef to
make the code a little less ugly. At least for the 2nd hunk in your patch
this would work well:

	if (IS_ENABLED(CONFIG_MEMORY_FAILURE) &&
	    (fault & (VM_FAULT_HWPOISON|VM_FAULT_HWPOISON_LARGE)))
		no_context(regs, error_code, address, SIGBUS, BUS_MCEERR_AR);
	else
		no_context(regs, error_code, address, SIGBUS, BUS_ADRERR);

The first hunk might need a bit more thought.

-Tony