Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115170907.24498-1-peterx@redhat.com> <20210115170907.24498-22-peterx@redhat.com>
 <CAJHvVcg4tjgRis=WF77phGC6Xm=DBo1W5pDa_d0ZP-Df1VXRxw@mail.gmail.com> <20210129223129.GB260413@xz-x1>
In-Reply-To: <20210129223129.GB260413@xz-x1>
From:   Axel Rasmussen <axelrasmussen@google.com>
Date:   Sat, 30 Jan 2021 00:08:44 -0800
Message-ID: <CAJHvVcjaLW23z9yJeSQR=R3PuRFEzWEHmOBkMiLEaYFnQ0OuuQ@mail.gmail.com>
Subject: Re: [PATCH RFC 21/30] hugetlb: Pass vma into huge_pte_alloc()
To:     Peter Xu <peterx@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Jerome Glisse <jglisse@redhat.com>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Hugh Dickins <hughd@google.com>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 29, 2021 at 2:31 PM Peter Xu <peterx@redhat.com> wrote:
>
> On Thu, Jan 28, 2021 at 02:59:13PM -0800, Axel Rasmussen wrote:
> > > +pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma,
> >
> > This was pointed out to me just after I sent v3 of my series today
> > (which includes this patch):
> >
> > Typo, s/structt/struct/.
>
> Thanks Axel - fixed here too.  It's strange why it didn't complain.
>
> Re the minor fault series, I thought it would be good to have some comment from
> Andrea/Mike or others, but in all cases I'll read your v3 next week.
>
> (A small heads-up: you'd better use v3.1 next time for that single patch, so
>  that just in case there will be a complete v4 series then that patch won't
>  collapse with it)

Thanks!

And, I'll keep that in mind for next time. I had seen it done that way
before, but it slipped my mind.

>
> --
> Peter Xu
>