Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5137ab3793f03c17a719445f14131c16e7766434.camel@perches.com>
Subject: Re: [PATCH v3 28/34] misc: Intel tsens IA host driver.
From:   Joe Perches <joe@perches.com>
To:     mgross@linux.intel.com, markgross@kernel.org, arnd@arndb.de,
        bp@suse.de, damien.lemoal@wdc.com, dragan.cvetic@xilinx.com,
        gregkh@linuxfoundation.org, corbet@lwn.net,
        palmerdabbelt@google.com, paul.walmsley@sifive.com,
        peng.fan@nxp.com, robh+dt@kernel.org, shawnguo@kernel.org,
        jassisinghbrar@gmail.com
Cc:     linux-kernel@vger.kernel.org,
        "C, Udhayakumar" <udhayakumar.c@intel.com>, C@linux.intel.com
Date:   Fri, 29 Jan 2021 23:01:30 -0800
In-Reply-To: <20210130022124.65083-29-mgross@linux.intel.com>
References: <20210130022124.65083-1-mgross@linux.intel.com>
         <20210130022124.65083-29-mgross@linux.intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2021-01-29 at 18:20 -0800, mgross@linux.intel.com wrote:
> From: "C, Udhayakumar" <udhayakumar.c@intel.com>
> 
> Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> platforms.
[]
> diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c b/drivers/misc/intel_tsens/intel_tsens_host.c
[]
> +static int tsens_i2c_smbus_read_byte_data(struct i2c_client *i2c, u8 command,
> +					  u8 *i2c_val)
> +{
> +	union i2c_smbus_data data;
> +	int status;
> +
> +	status = i2c_smbus_xfer(i2c->adapter, i2c->addr, i2c->flags,
> +				I2C_SMBUS_READ, command,
> +				I2C_SMBUS_BYTE_DATA, &data);

this can fail

> +	*i2c_val = data.byte;

Is it appropriate to set the value if it failed and data was
not initialized?

> +	return status;
> +}
> +
> +/**
> + * intel_tsens_get_temp - get updated temperatue

Might want to use codespell on all files.