Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 30 Jan 2021 11:57:11 -0600
From:   Tyler Hicks <code@tyhicks.com>
To:     Joe Perches <joe@perches.com>
Cc:     trix@redhat.com, hannes@cmpxchg.org, mhocko@suse.com,
        longman@redhat.com, herbert@gondor.apana.org.au,
        ebiggers@google.com, ecryptfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eCryptfs: add a semicolon
Message-ID: <20210130175711.GB58096@elm>
References: <20201127160513.2619747-1-trix@redhat.com>
 <3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3168a3aa5c4ac564340cba2a151359e8cd3dee5f.camel@perches.com>
Precedence: bulk

On 2020-11-27 10:11:23, Joe Perches wrote:
> On Fri, 2020-11-27 at 08:05 -0800, trix@redhat.com wrote:
> > Function like macros should have a semicolon.
> []
> > diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c
> []
> > @@ -1172,7 +1172,7 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok,
> > ?	rc = ecryptfs_cipher_code_to_string(crypt_stat->cipher, cipher_code);
> > ?	if (rc) {
> > ?		ecryptfs_printk(KERN_ERR, "Cipher code [%d] is invalid\n",
> > -				cipher_code)
> > +				cipher_code);
> 
> As this is the only use that does not have a semicolon,
> it'd be good to add the removal of the semicolon from
> the #define at the same time.

I double checked that this is the only ecryptfs_printk() usage missing
the trailing semicolon and then made Joe's suggested change before
pushing the patch to the eCryptfs next branch:

 https://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git/log/?h=next

Thanks for the cleanup!

Tyler