Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] HID: logitech-dj: add support for keyboard events in
 eQUAD step 4 Gaming
To:     =?UTF-8?Q?Filipe_La=c3=adns?= <lains@riseup.net>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        linux-kernel@vger.kernel.org
References: <20210130191027.1225465-1-lains@archlinux.org>
 <265604c19e2e875ca17e4cf713000492b9ffd8d8.camel@riseup.net>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <0a3aa6fb-3f22-d6f5-1748-42430f6e7ccc@redhat.com>
Date:   Sat, 30 Jan 2021 21:27:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <265604c19e2e875ca17e4cf713000492b9ffd8d8.camel@riseup.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 1/30/21 8:14 PM, Filipe Laíns wrote:
> Hans,
> 
> You added support for non unifying receivers in
> 74808f9115cee2bb53e7161432959f3e87b631e4, could you please test and make sure
> this cause any breakage with your devices?
> 
> AFAIK, they could only break if they have a 0x01 report which is different from
> kbd_descriptor.

I don't have any receivers hitting the "case 7" which you are modifying,
so I don't expect to see any effects of this change on my hw.

Regards,

Hans