Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2811745pxb; Sat, 30 Jan 2021 15:55:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJyt0LtgUAwMjQgepYfhpD4Zl6Ra16i3PL5biY6KE3QEqX3QBsITJokmohMh4nAjXlCFRZqu X-Received: by 2002:a05:6402:160f:: with SMTP id f15mr12052515edv.348.1612050949681; Sat, 30 Jan 2021 15:55:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612050949; cv=none; d=google.com; s=arc-20160816; b=O8gWftE48kYqRL0izULpohlufWgWHMP2G3okPzHM90ZQVokqYpxZkHf31VcMRG+dPl AYGLE4O/o5f+aMLO5cO9aXYTUOinezCO7yUm2e8EVvm/bY1/TYz5CjZhq9lrtwkZ02DT sREGrBoqUYMY+I2/O8V2yIMgca8/xtd1tCiRfo/3DCbnH8SdRh6OePv7euy6cWtuv07X e7m1ahSi9a3ro/23WTK6QqP4l5DQYQVhmcKvR6tTesz5E8uerG/N4KrQnC89CuHcPNyU M4hVYX6ATkTCBWYlJyZaqTYdL/q6jujshPm8ILwSBaZGD3u4eqtr/Ga6O4DZt2r8NPCf lyGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=hXqMe0IwdKtjlrSdIaiIQkYbKycgx0fvocNVQwP5CeI=; b=ljgWmVCb5WwM5HsfjDxA+Udq413ztuksb+McS4SSF/O1fBqQYYJcgFcIhWSa00Qqnb B79tFCQzzhR8rlQrt+W1hyMAM2UNW2yarWXLwubni0F/AbN/sbjaOd8sq3lycCZi2+Sz HQvnZ6laXOZ1T+nxEz/+uTpyPCl5FI2nROU1Ll+7X6urD2W9yIDgOWEJjpMbjTE8IguJ zzyLXJhRqaTW1MgqFoVPbKD+6CJnoCiDq6xvVj8Z2GyWqdmc37UwURSQz0lCBcH1jtTy cv6Atg2NnWPAgeUSzATIXyNO4OwF7oO0m4NZiIj2qEFOW0MGLNBp9OLQRChr88YSFnic WdPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="X3/qsRDu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si344160ejp.679.2021.01.30.15.55.25; Sat, 30 Jan 2021 15:55:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="X3/qsRDu"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbhA3XwN (ORCPT + 99 others); Sat, 30 Jan 2021 18:52:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbhA3Xt4 (ORCPT ); Sat, 30 Jan 2021 18:49:56 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55ABFC061573; Sat, 30 Jan 2021 15:49:13 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id k142so49605oib.7; Sat, 30 Jan 2021 15:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hXqMe0IwdKtjlrSdIaiIQkYbKycgx0fvocNVQwP5CeI=; b=X3/qsRDuRHaEY4Ed783smUblt/e1GbCZDvGY/HSBIwKIlTJHsjHBe/3aUE+opWkv2h f+7SqQ2jZidD/3Y4r9EhFoSogD0lI7AC+D64Dn8YDsIUD9X8WoA+cMLs8BjPeLc7ny+y b+M6TNNWaw7JGpmtFOEMGKTbL8WItfRO1X/TeyS6upEod1vX6MWKSy272+4wNbXnepRx uzpRdFbIXFRzmfCBAvdlQd51RJBvShRFEBsW94+yAHsA/iY3soXlrPCpvnbdyH7QHus9 2ZhE6C2Vv3reXocpciw+1VKaTPgDWHyaisRzAWV65bXLkRoLhHmhHmDp/021TcUJV/Au RAow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hXqMe0IwdKtjlrSdIaiIQkYbKycgx0fvocNVQwP5CeI=; b=nOYGPPqrFD8aCWjtMwLl9vSrIXJs2wFNv2qHa8Jfr0E6WRuluNCIJ5ngkMBLLBNF2g NH+yEoAJXMC7ybJBiOqXAWkRmF+Vrg5qF1IXQ9cHW4sYr/d4s1KoVlJ8Y0P4o0nkhdne OtXQfIX3V5SGp97lAJkrzEmhZhRHNDvlQ6t8cdTNiPh9/0STJ4kOkAQJHN2HRcPeeg0c ZJYFz8MUalTVJa9uvxFqW4338LL7+4a5ZqNkXRLUfSEVFcUMxcMsRby8Ae8I2sFCr/+H K3/xuPh2I7h0SahUnQ0TdecG4XYmFDx5ZoGtYxzy/nBci15x133d2clDvQEejnf7mtLu CSJg== X-Gm-Message-State: AOAM531qUIncnrMhxs1HQdlNaPztqWbwgl0CxkkEomYggryfEyHWsyfO fGp8orTh7NkuYdCeVmoafXlmd1o/Hkg= X-Received: by 2002:aca:ab14:: with SMTP id u20mr6694738oie.117.1612050552772; Sat, 30 Jan 2021 15:49:12 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id o25sm3403631oie.57.2021.01.30.15.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Jan 2021 15:49:11 -0800 (PST) Sender: Guenter Roeck Subject: Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls To: Jarkko Sakkinen , =?UTF-8?Q?=c5=81ukasz_Majczak?= Cc: Peter Huewe , Jason Gunthorpe , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Marcin Wojtas , Alex Levin , James.Bottomley@hansenpartnership.com References: <20210123014247.989368-1-lma@semihalf.com> <20210125171846.GA31929@roeck-us.net> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <7a702108-ec9e-b2e2-be89-3590437c0eb5@roeck-us.net> Date: Sat, 30 Jan 2021 15:49:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/21 2:59 PM, Jarkko Sakkinen wrote: > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Ɓukasz Majczak wrote: >> Hi Jarkko, Guenter >> >> Yes, here are the logs when failure occurs - >> https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 >> Look for a phrase "TPM returned invalid status" >> >> Guenter - good suggestion - I will try to keep it as tight as possible. >> >> Best regards, >> Lukasz > > Is it possible for you try out with linux-next? Thanks. It's a known > issue, which ought to be fixed by now. > > The log message is harmless, it'a warning not panic, and does not > endanger system stability. WARN()'s always dump stack trace. No oops > is happening. > There is a note in the kernel documentation which states: Note that the WARN()-family should only be used for "expected to be unreachable" situations. If you want to warn about "reachable but undesirable" situations, please use the pr_warn()-family of functions. It seems to me that "harmless" doesn't really fit the expected use of WARN(). Should it possibly be converted to pr_warn() ? Thanks, Guenter