Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2839621pxb;
        Sat, 30 Jan 2021 17:08:19 -0800 (PST)
X-Google-Smtp-Source: ABdhPJylXwRagnEghDwMa8zCYnh2Nktx2B1QqzEST1pmDxh+UMIG97ioC8ambdmpq4JAtabe4SxY
X-Received: by 2002:a17:906:e085:: with SMTP id gh5mr11256879ejb.418.1612055299745;
        Sat, 30 Jan 2021 17:08:19 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612055299; cv=none;
        d=google.com; s=arc-20160816;
        b=QdrYhhFwl+KhNABIf/wLFgW6y5SBT2fWgq4KC3iJgta1r4tRyKuRQXPklN2HU8DwcE
         fI/ndWkFefBLv1WgeVqlTkCwP1+7gJIgmoweRWYU82l4vdvKpxppDkVBcpHa7QyPXgNm
         3+CQBBbA/ezFaivFnpDPbwqJFKO+ezWLaULbH6NItPVLfNC7nmhHpqWnabEVsMYk9WT9
         qRt0KhpuZSP4hiVwv2Tm59xZGRYAqfWYv5RVFHFBW1gBdmPqwg1mXRWy0aBb3vfHN4sM
         sQWuoRG4q6/jxhxNksOCao3jFyIHZoBynvDhlSSuF413igUVvQ4YWMkDLpkAIfaJc3wa
         qtHw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=d0735n6S/Vm5Q8cSSbumHsQrStTHOJtD0MC5+xI4v2Q=;
        b=ecVnmUQlQzpsw2a255x8+nXfi6OkDwltknl74sPQQ/LJpcJFH9fHL52TBSgHnftbdX
         IqBtKgKdz4PeM7C/xG0qnqSwZCjK1OVVqhQm89qqmzp/1ScERiAroGk2Vuoh2VVa3a4f
         UQJtsICSI0dq5XudaXdpxoYLZRk3dHArXu6jObtnIMCx5Lsz6J5+V+6Ad56v4MgLgtH6
         icCNa3s5T9idxI+b64LDEmETcfJoKZwC6XveEndPz4X+zSV3rxSSYkLPbMV0lYJTLM0V
         eOXjHug0Wkr8iEX7BoiCHWS1RfoHNN231wFoTUKOLcaP/59oVpcV7WLSjXzekvkMX7e4
         F54w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRt+2gfR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id w24si7872633eje.339.2021.01.30.17.07.55;
        Sat, 30 Jan 2021 17:08:19 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRt+2gfR;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232258AbhAaBDK (ORCPT <rfc822;lizhong0730@gmail.com>
        + 99 others); Sat, 30 Jan 2021 20:03:10 -0500
Received: from mail.kernel.org ([198.145.29.99]:48290 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230360AbhAaBDJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 30 Jan 2021 20:03:09 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 3E33064E17
        for <linux-kernel@vger.kernel.org>; Sun, 31 Jan 2021 01:02:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1612054949;
        bh=d0735n6S/Vm5Q8cSSbumHsQrStTHOJtD0MC5+xI4v2Q=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=TRt+2gfRF55vRA4ZYI+7bti3FB92qTfJN9Ri5+/0PziY3lTJpJ6VNQnkOO0l2SSHr
         F1tfVyu2W0ayplfrflQApRI8fEEEmA+QRyU2XdOyuf7x56e/pHGQNKo39yUvKRTMQ0
         HUwpSwVg3926TJHX9MO6JdiUDihqbz1MKoqgGb9/XhkJUeI365X7t+pTBflx8QI4qv
         cQ4Q9nc1UaJW+h5ypfWrmhofz5M6EnT70LOWOv//igikmEeQL8Pf72wT+USgq/PnKg
         oyAsBj9GZYT4721F3FGDxXqIV5spPWz2i+DTIajM3Fhfu9oVbq9peJ0tRyzL/TrQU7
         7alZHZ11nscuw==
Received: by mail-ej1-f44.google.com with SMTP id kg20so18723261ejc.4
        for <linux-kernel@vger.kernel.org>; Sat, 30 Jan 2021 17:02:29 -0800 (PST)
X-Gm-Message-State: AOAM530a4P3qzfySMSLksIXGp3QE3Ny6yry7aF2sFCgMxO1Wz8Cl2V4H
        r53V2lG6y6bnAIKoUCcBqMOFdXvw1/qa8E6uy+JNiw==
X-Received: by 2002:a17:906:5608:: with SMTP id f8mr11140726ejq.101.1612054947857;
 Sat, 30 Jan 2021 17:02:27 -0800 (PST)
MIME-Version: 1.0
References: <20210131001132.3368247-1-namit@vmware.com> <20210131001132.3368247-2-namit@vmware.com>
In-Reply-To: <20210131001132.3368247-2-namit@vmware.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Sat, 30 Jan 2021 17:02:16 -0800
X-Gmail-Original-Message-ID: <CALCETrXsbaHJ+riUjWUJyrAaSyoFmRs17q=6ytf3vC2uYNL0sQ@mail.gmail.com>
Message-ID: <CALCETrXsbaHJ+riUjWUJyrAaSyoFmRs17q=6ytf3vC2uYNL0sQ@mail.gmail.com>
Subject: Re: [RFC 01/20] mm/tlb: fix fullmm semantics
To:     Nadav Amit <nadav.amit@gmail.com>
Cc:     Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        Nadav Amit <namit@vmware.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <will@kernel.org>, Yu Zhao <yuzhao@google.com>,
        Nick Piggin <npiggin@gmail.com>, X86 ML <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 30, 2021 at 4:16 PM Nadav Amit <nadav.amit@gmail.com> wrote:
>
> From: Nadav Amit <namit@vmware.com>
>
> fullmm in mmu_gather is supposed to indicate that the mm is torn-down
> (e.g., on process exit) and can therefore allow certain optimizations.
> However, tlb_finish_mmu() sets fullmm, when in fact it want to say that
> the TLB should be fully flushed.

Maybe also rename fullmm?