Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: DRbJGk0FLzKR/3hPOLFdVkPowsBSZpCNMFJfRwpm3XNkL3QjQGtZhs2CY47XxuSB48BmjgRfAj
 4RdgJGhX3W4n/pJCV72L6gtd1pi6C3m2kzG+IMPoUnBmyCVJLSHLrM6luWVkxeh2XZ+31EJWKD
 KXQWHpgbJIO/T7UvZcKVNqycp/vCSVLtH1EvbDjyiVmRgjMAW9YiGSUoIctPvmE/P9EJjO7NUA
 E/9bXaKifq3NB41gK6EDCiLMUMubt5LWT2d/AvlNjfOSX/Sen1qNLXOFLzGRL4YApIUxO+MHWA
 85U=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <Avi.Shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init
Thread-Topic: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init
Thread-Index: AQHW9L7nyZFYPn4n3Ei9SDx+7JRxj6o7liWAgAW9V4CAAAQJAIAAAHog
Date:   Sun, 31 Jan 2021 07:17:14 +0000
Message-ID: <DM6PR04MB6575FCFF50C07C2C37C612E1FCB79@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210127151217.24760-1-avri.altman@wdc.com>
 <20210127151217.24760-2-avri.altman@wdc.com> <YBGEh4cfPldXoQxI@kroah.com>
 <DM6PR04MB65756785F53B6D9FDE581013FCB79@DM6PR04MB6575.namprd04.prod.outlook.com>
 <YBZYfM/NjTo1lbGi@kroah.com>
In-Reply-To: <YBZYfM/NjTo1lbGi@kroah.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 14020a22-8d6b-4643-3d09-08d8c5b83bf4
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2021 07:17:14.2854
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mvke/FbdbAU+Ll/bWrALqiwBMDADMULcwEzRr9m3UVGFQiW0HBZHE34LdfM2nkN72G+eMRPEIg+smLp97a0AuQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0268
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Sun, Jan 31, 2021 at 07:08:00AM +0000, Avri Altman wrote:
> > > >
> > > > +static enum UFSHPB_MODE ufshpb_mode;
> > >
> > > How are you allowed to have a single variable for a device-specific
> > > thing?  What happens when you have two controllers or disks or whatev=
er
> > > you are binding to here?  How does this work at all?
> > >
> > > This should be per-device, right?
> > Right. Done.
> >
> > Not being bickering,  AFAIK, there aren't, nor will be in the foreseen =
future,
> any multi-ufs-hosts designs.
>=20
> Why not?  What prevents someone from putting 2 PCI ufs host controllers
> in a system tomorrow?
>=20
> > There were some talks in the past about ufs cards, but this is official=
ly off
> the table.
>=20
> Never say never :)
>=20
> Seriously, how can you somehow ensure that a random manufacturer will
> not do this?
Better let the platform vendors answer this.

As for your comment - you are obviously right - I will fix this.

Thanks,
Avri