Date: Tue, 19 Sep 2006 11:32:00 -0500
From: Olof Johansson <olof@lixom.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dan Williams <dan.j.williams@gmail.com>, christopher.leech@intel.com,
       Jeff Garzik <jeff@garzik.org>, neilb@suse.de,
       linux-raid@vger.kernel.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: clean up and abstract function types (was
 Re: [PATCH 08/19] dmaengine: enable multiple clients and operations)
Message-ID: <20060919113200.2afa1549@pb15>
In-Reply-To: <1158664809.32598.4.camel@localhost.localdomain>
References: <1158015632.4241.31.camel@dwillia2-linux.ch.intel.com>
	<20060911231817.4737.49381.stgit@dwillia2-linux.ch.intel.com>
	<4505F4D0.7010901@garzik.org>
	<20060915113817.6154aa67@localhost.localdomain>
	<20060915144423.500b529d@localhost.localdomain>
	<e9c3a7c20609181556n235d650eg16e5296f192bd2d5@mail.gmail.com>
	<20060918200555.74aedeae@localhost.localdomain>
	<1158664809.32598.4.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1184
Lines: 34

On Tue, 19 Sep 2006 12:20:09 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> Ar Llu, 2006-09-18 am 20:05 -0500, ysgrifennodd Olof Johansson:
> > On Mon, 18 Sep 2006 15:56:37 -0700 "Dan Williams" <dan.j.williams@gmail.com> wrote:
> 
> > op.src_type = PG; op.src = pg;
> > op.dest_type = BUF; op.dest = buf;
> > op.len = len;
> > dma_async_commit(chan, op);
> 
> At OLS Linus suggested it should distinguish between sync and async
> events for locking reasons.
> 
> 	if(dma_async_commit(foo) == SYNC_COMPLETE) {
> 		finalise_stuff();
> 	}
> 
> 	else		/* will call foo->callback(foo->dev_id) */
> 
> because otherwise you have locking complexities - the callback wants to
> take locks to guard the object it works on but if it is called
> synchronously - eg if hardware is busy and we fall back - it might
> deadlock with the caller of dmaa_async_foo() who also needs to hold the
> lock.

Good point, sounds very reasonable to me.


-Olof
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/