Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 31 Jan 2021 10:58:44 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        Douglas Anderson <dianders@chromium.org>,
        Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity
 driver
Message-ID: <20210131105844.2dfe9380@archlinux>
In-Reply-To: <161159998973.76967.1213998704222248070@swboyd.mtv.corp.google.com>
References: <20210122225443.186184-1-swboyd@chromium.org>
        <20210122225443.186184-4-swboyd@chromium.org>
        <20210124173820.4528b9c9@archlinux>
        <161159998973.76967.1213998704222248070@swboyd.mtv.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

...
> > > +
> > > +#ifdef CONFIG_OF  
> > 
> > As a general rule, we are trying to clear out protections on CONFIG_OF etc
> > and use of of_match_ptr() on the basis they don't really gain us anything
> > and prevent use of some other firmware types.  Here I guess you know what
> > your firmware looks like, but I'm still keen to drop it in the interests
> > of there being fewer places to copy it from.
> > 
> > It may be a good idea to give this a more specific name as well given
> > we already have cros-ec-prox as a platform device id from
> > the cros_ec_light_prox driver.  
> 
> Alright. I renamed it to cros_ec_mkbp_proximity throughout this driver.
> I'm concerned about dropping CONFIG_OF because of_match_ptr() and
> CONFIG_OF=n makes it unused but I suppose that will be OK as long as
> compilation passes.

It's a trivial overhead + note that it can be used by certain ACPI
tables.  Lookup the delights of PRP0001 which lets ACPI use
device-tree descriptions.  It may well be that no one uses that for
this driver, but it's nice not to exclude it and that works with
CONFIG_OF=n.

Jonathan