Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3156367pxb; Sun, 31 Jan 2021 06:12:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxzah6de/mnO2oi9smuxAiDuY3r1mUCt8fc6Fb9MtVYd5R13qry/ruxNXhBud4cBjUT+sPs X-Received: by 2002:a17:906:c1c1:: with SMTP id bw1mr13588707ejb.86.1612102338133; Sun, 31 Jan 2021 06:12:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612102338; cv=none; d=google.com; s=arc-20160816; b=h68RYgcWCBuo3VAYQEkpRhbctEyN4YzaPSOm+NcmOdtMxMAqYocYj9HMhJBQj3Zf/f nRCfCLeMR8OuhuN3BV49jkJxQON9LtbpatN+TkxsBg+mz5ceq6ev0mGsHUxsvomIL/f1 hg5HjZ/MV1MLByL/x/YK6HIttQxt3v/q2lLxAifr/eRhng9G6EW354HMrvwkeUCCThoy cXT9H7qXIxjAcaU0DaZh96g1zLPLENtmePXt8tbrfmAgZBQtfyEnQBjO/DVMm5lMBhPY WloCOS10XKKNp5MvqC3i9Ti9npIPFPcVdUIplpNRFMcp3YA6yEV2D4kFPLkJrDMH/dGs ntQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=R8+JxZSpbHiMxsv5TLCmqmv2hyGPLbx0zPwRvsESoT8=; b=u2ferCQMXuYxHmsz0UmvxYOo5UTE6iPk9ZvhnAzJk6UWP7svadQ1YkkUxeLwG+NBjf REYnjX8h9zU+rcPXrSzv07kPeYfQj3e3h3hJk4h94E+z/YhPBmaTPeslOTNXRpMVU/8l uWSASRsN+fcPYO4JgXt4OGFuDwyklmHm9OVg/rv12voKgLq+GEeTMzYmm0jJBb5sbJSm hjTegpvTrm21hmEtxI1hPsfH9Fbe7zds5V0YOJQva42QefNClFrCu+a++pXIm/i5TAUE qtSr3XDCHj5H3CRXwKHSEFOynHEYt4eruw9Ai5fn7Hxw4lg+usxuOFW1PQhonwqdieyu Cwmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Va5+mSbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr35si8802293ejc.274.2021.01.31.06.11.53; Sun, 31 Jan 2021 06:12:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Va5+mSbb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231459AbhAaOJY (ORCPT + 99 others); Sun, 31 Jan 2021 09:09:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231953AbhAaMhF (ORCPT ); Sun, 31 Jan 2021 07:37:05 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1A99C061573; Sun, 31 Jan 2021 04:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R8+JxZSpbHiMxsv5TLCmqmv2hyGPLbx0zPwRvsESoT8=; b=Va5+mSbba56ABTdMGmAv/C++pK /W28Q6TwZmVEZsX8HgZZ/HPOcp3zr1hv4YthleldIqNIt6uZunVSsFBBPx7eVDMAcIxW/UPzjIBK5 JzdEItl1XJXViz7h1EG+4LZkx3G5PCgKizGxtld/r8iEXwUUG3e0JVvNMhEfSDlbaT/yh74y4FaJ8 QQQnRSuWCRET8KgpOA/4ZSLVJTDpR5loU560WdMG4vfu8TxXuXVk3Rol1BRuFWcMico3hLQmcDDsg oMCrWMWO9JPD3DrPG2o6sr2SJtf2cN0pjPpXTlIBrnkM+qtkIE0xt/2OAwNKiOgwxuI2ErKOc6zc5 R124FSfg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l6Blc-00CQnr-Gg; Sun, 31 Jan 2021 12:23:48 +0000 Date: Sun, 31 Jan 2021 12:23:48 +0000 From: Matthew Wilcox To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 net-next 5/5] net: page_pool: simplify page recycling condition tests Message-ID: <20210131122348.GM308988@casper.infradead.org> References: <20210131120844.7529-1-alobakin@pm.me> <20210131120844.7529-6-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210131120844.7529-6-alobakin@pm.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2021 at 12:12:11PM +0000, Alexander Lobakin wrote: > pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, > this function is just a redundant wrapper over page_is_pfmemalloc(), > so inline it into its sole call site. Why doesn't this want to use {dev_}page_is_reusable()?