Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ygyXPUKZKG3oZDYENr7E4vckWjxFhovOT9pHZ5lfVSoURtvjW83TMkVFLuuzALrbh+yfm3Ybzn
 OI84anvsaJCPEsp0jhLy8swZKLowgOp5BYA8yqif9Kw17LHeJjEhE/h3VUBELseH9IheQV1BT+
 MUnBzZjOWVTikJEwwyP+P1EoynKF3S8qTQUUHg2sBcGSsv0AyGUEEY2u7GygBIen7ygAwOPe6/
 qZxR/LHKExzFyMRcNmXH590TwAJXc6VedYb+Wb8lvJqCfcFEPH/Z+atJ3Lmv3Ld2XsciYNu2eE
 SXs=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Nitin Rawat <nitirawa@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stummala@codeaurora.org" <stummala@codeaurora.org>,
        "vbadigan@codeaurora.org" <vbadigan@codeaurora.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>
CC:     "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Bao D . Nguyen" <nguyenb@codeaurora.org>
Subject: RE: [PATCH V1 1/3] scsi: ufs: export api for use in vendor file
Thread-Topic: [PATCH V1 1/3] scsi: ufs: export api for use in vendor file
Thread-Index: AQHW9ZZmo/O9RzKnuUyM4+Bc9yWaJ6pBxLcw
Date:   Sun, 31 Jan 2021 13:59:56 +0000
Message-ID: <DM6PR04MB657574D3D8B99F3A4997D810FCB79@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1611852899-2171-1-git-send-email-nitirawa@codeaurora.org>
 <1611852899-2171-2-git-send-email-nitirawa@codeaurora.org>
In-Reply-To: <1611852899-2171-2-git-send-email-nitirawa@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 92fec424-57f3-4f03-06b3-08d8c5f07dbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2021 13:59:56.3461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tGo2kpJIxNBMDA0FnmNFeWJfXHy6PqiZj4e+ne41aXZWQZyVANG3KpIBKukDfrlP25IcgTSi2su7W7gPoLhEag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB7129
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Exporting functions ufshcd_set_dev_pwr_mode, ufshcd_disable_vreg
> and ufshcd_enable_vreg so that vendor drivers can make use of
> them in setting vendor specific regulator setting
> in vendor specific file.
As for ufshcd_{enable,disable}_vreg - maybe inline ufshcd_toggle_vreg and u=
se it instead?

>=20
> Signed-off-by: Nitin Rawat <nitirawa@codeaurora.org>
> Signed-off-by: Bao D. Nguyen <nguyenb@codeaurora.org>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 9 ++++++---
>  drivers/scsi/ufs/ufshcd.h | 4 ++++
>  2 files changed, 10 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 9c691e4..000a03a 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8091,7 +8091,7 @@ static int ufshcd_config_vreg(struct device *dev,
>         return ret;
>  }
>=20
> -static int ufshcd_enable_vreg(struct device *dev, struct ufs_vreg *vreg)
> +int ufshcd_enable_vreg(struct device *dev, struct ufs_vreg *vreg)
>  {
>         int ret =3D 0;
>=20
> @@ -8110,8 +8110,9 @@ static int ufshcd_enable_vreg(struct device *dev,
> struct ufs_vreg *vreg)
>  out:
>         return ret;
>  }
> +EXPORT_SYMBOL(ufshcd_enable_vreg);
Why do you need to export it across the kernel?
Isn't making it non-static suffices?
Do you need it for a loadable module?

>=20
> -static int ufshcd_disable_vreg(struct device *dev, struct ufs_vreg *vreg=
)
> +int ufshcd_disable_vreg(struct device *dev, struct ufs_vreg *vreg)
>  {
>         int ret =3D 0;
>=20
> @@ -8131,6 +8132,7 @@ static int ufshcd_disable_vreg(struct device *dev,
> struct ufs_vreg *vreg)
>  out:
>         return ret;
>  }
> +EXPORT_SYMBOL(ufshcd_disable_vreg);
>=20
>  static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on)
>  {
> @@ -8455,7 +8457,7 @@ ufshcd_send_request_sense(struct ufs_hba *hba,
> struct scsi_device *sdp)
>   * Returns 0 if requested power mode is set successfully
>   * Returns non-zero if failed to set the requested power mode
>   */
> -static int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
> +int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
>                                      enum ufs_dev_pwr_mode pwr_mode)
>  {
>         unsigned char cmd[6] =3D { START_STOP };
> @@ -8513,6 +8515,7 @@ static int ufshcd_set_dev_pwr_mode(struct ufs_hba
> *hba,
>         hba->host->eh_noresume =3D 0;
>         return ret;
>  }
> +EXPORT_SYMBOL(ufshcd_set_dev_pwr_mode);
>=20
>  static int ufshcd_link_state_transition(struct ufs_hba *hba,
>                                         enum uic_link_state req_link_stat=
e,
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index ee61f82..1410c95 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -997,6 +997,10 @@ extern int ufshcd_dme_get_attr(struct ufs_hba *hba,
> u32 attr_sel,
>                                u32 *mib_val, u8 peer);
>  extern int ufshcd_config_pwr_mode(struct ufs_hba *hba,
>                         struct ufs_pa_layer_attr *desired_pwr_mode);
> +extern int ufshcd_set_dev_pwr_mode(struct ufs_hba *hba,
> +                                               enum ufs_dev_pwr_mode pwr=
_mode);
> +extern int ufshcd_enable_vreg(struct device *dev, struct ufs_vreg *vreg)=
;
> +extern int ufshcd_disable_vreg(struct device *dev, struct ufs_vreg *vreg=
);
>=20
>  /* UIC command interfaces for DME primitives */
>  #define DME_LOCAL      0
> --
> 2.7.4