Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: MHOYHFiLNm6kx8UTBzMp9T90QjgezWr3FKv8vD2z3Tdlpas8Xixrbz3bNNItJGU/5Zgt1afeIF
 zh/ZpME2GoLv3XMI2HFGkT1QRTqHTSEY6GAa3+pNje7l/9XbucZEEK3C+ExZMiooHKwlo41ato
 um24/6l++/nZlMJH3zXjmD1krDDadiNVaHGTzaDEW9yNlHfJt2cRVn2lxuUTympy4EpEvnSBUR
 /YSor3c4p5vpppMGKEJfM5PEL+UKE5Me4p8uF2pKoaa18niTP7wFQAYkeEyL/sCNZnb8zRXc+6
 Aqo=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Nitin Rawat <nitirawa@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stummala@codeaurora.org" <stummala@codeaurora.org>,
        "vbadigan@codeaurora.org" <vbadigan@codeaurora.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>
CC:     "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V1 0/3] scsi: ufs: Add a vops to configure VCC voltage
 level
Thread-Topic: [PATCH V1 0/3] scsi: ufs: Add a vops to configure VCC voltage
 level
Thread-Index: AQHW9ZZmeK7PA8AawUSfMfIJOx/dhapBx6jw
Date:   Sun, 31 Jan 2021 14:02:12 +0000
Message-ID: <DM6PR04MB6575D0348161330D21A9B6C5FCB79@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <1611852899-2171-1-git-send-email-nitirawa@codeaurora.org>
In-Reply-To: <1611852899-2171-1-git-send-email-nitirawa@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 78840d30-e7b7-4157-56d0-08d8c5f0cf0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2021 14:02:12.8588
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RjIuSDwKa7hU7wUUQhGeXvQ99ezMLZ74m1Gsn4irPE6k692ffasCUmcXOiCEUXgL35n3wL9PJc42UakuideftA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB7129
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> UFS specification allows different VCC configurations for UFS devices,
> for example,
>         (1)2.70V - 3.60V (For UFS 2.x devices)
>         (2)2.40V - 2.70V (For UFS 3.x devices)
> For platforms supporting both ufs 2.x (2.7v-3.6v) and
> ufs 3.x (2.4v-2.7v), the voltage requirements (VCC) is 2.4v-3.6v.
> So to support this, we need to start the ufs device initialization with
> the common VCC voltage(2.7v) and after reading the device descriptor we
> need to switch to the correct range(vcc min and vcc max) of VCC voltage
> as per UFS device type since 2.7v is the marginal voltage as per specs
> for both type of devices.
>=20
> Once VCC regulator supply has been intialised to 2.7v and UFS device
> type is read from device descriptor, we follows below steps to
> change the VCC voltage values.
>=20
> 1. Set the device to SLEEP state.
> 2. Disable the Vcc Regulator.
> 3. Set the vcc voltage according to the device type and reenable
>    the regulator.
> 4. Set the device mode back to ACTIVE.
>=20
> The above changes are done in vendor specific file by
> adding a vops which will be needed for platform
> supporting both ufs 2.x and ufs 3.x devices.
The flow should be generic - isn't it?
Why do you need the entire flow to be vendor-specific?
Why not just the parameters vendor-specific?

Thanks,
Avri