Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 08/29] dma-buf: Avoid comma separated statements
To:     Joe Perches <joe@perches.com>, Jiri Kosina <trivial@kernel.org>,
        Sumit Semwal <sumit.semwal@linaro.org>
Cc:     linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <cover.1598331148.git.joe@perches.com>
 <990bf6f33ccaf73ad56eb4bea8bd2c0db5e90a31.1598331148.git.joe@perches.com>
 <a87b95d11c22d997ebc423bba71cabef15ca0bac.camel@perches.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <4d5891b7-ea87-974e-d260-f78c3af326bc@amd.com>
Date:   Wed, 3 Feb 2021 14:26:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <a87b95d11c22d997ebc423bba71cabef15ca0bac.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by AM8P191CA0028.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17 via Frontend Transport; Sun, 31 Jan 2021 17:26:23 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 359c3818-7be5-42cc-5776-08d8c60d5589
X-MS-TrafficTypeDiagnostic: MN2PR12MB4208:
X-Microsoft-Antispam-PRVS: <MN2PR12MB4208489FE1D0F94C09AF44EE83B79@MN2PR12MB4208.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:95;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kUD2gJD5O4YJyp3jb1xuj3xvP2LAGpHJ2bs8KPZgDfEHlDgVGXgs4qFbANS8+3LCzvUGlNrMkUo794jBcQd7kQ29KunSKE29f50M2D500kqROW78dpsHWLBWRSPCRvCkIXd2ID2mgwyptXxWPveo+Lm4su9rbw+iL7DJYK3qVwpKQwgCq5+DG+Y/BUl7kXFIV6vHFsrYBHqd1Y4lk+lvalScJSzzIKyOvty2nRRyh9n05bsJMfrdoGb6IxMCjzjWtXhVDIVQVIFAnRkKzmrT59iX8VQWGV5cPvm5GpUP9RvewzeajK1sRwBowuAipusRrO38+OTVWF+Cpr9Q0yIWGxJHQnz/fwLDUy/C8XZ6HjfdSWlg5yx5pLtzUmSJoLdNtPoN9YXyi8rqmKiDmgJcMrOHrNb53SfFHRFqetL0cWedAAJvry/8f/gfWXfqkmiWpEKCApyJuRvt8/H2/LNWDnhgcpAc5UYE0YZ6Oyhx4hllhqhVzs7DF6fahGNVQXzyKon7xxW5hoskn8Vo+dq6K++msnS38Eass7ydtRTeO0RBCxzPcHa89YItXYjJpvMc/fggRDg2VqYHXfDEiJs2k5Hj4YEA5jy9Ro3s2Y9V/8Y=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(39850400004)(376002)(366004)(316002)(36756003)(6666004)(6486002)(31686004)(110136005)(52116002)(83380400001)(31696002)(8936002)(2616005)(4326008)(478600001)(5660300002)(2906002)(86362001)(4744005)(66556008)(16526019)(8676002)(66476007)(66946007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?amQ4aGVNS2hJcWc5dWErQmtkQ1JzOHBMaHl3SWdCMDIxQytURnkrNkdwT2h3?=
 =?utf-8?B?djZXUnNyY1p0aGhqK3hMK0poRlhKbjBHbFhvL3NLdlFENVlrUmwrSVlYMVFR?=
 =?utf-8?B?TFhPMUdWdkJKRDNFNU9HUlM0YTZhckpNaGpWektRbXNXdUw2UXJNR0RHMk0x?=
 =?utf-8?B?YmpBTFYwMnV4Tjh6WldZamwwNG5vbllibU9DcTQzMHV6NzBCaTNQT09IcWNi?=
 =?utf-8?B?QTBXVnFmOEZiK0luUGViK3FzV2JMV2FmdGNPazdMTWlqK3lXYzdQbVNkNWxa?=
 =?utf-8?B?UU84ZDAza2MzbENkOXBCVU10NkJENklRVmloTkpzSHFQNFdoUDdxTU9oM3Z0?=
 =?utf-8?B?Z1daVzFKMFdmZzk4ZCtCc2NKRTRmYnVtckp6U3F1Y1dsUWxrUW1Ib1h6a0VD?=
 =?utf-8?B?WUY5d0I1WTRhQllBUi9XSkxMY3NINHZRQkJrOGducFZrcEFvUWgyZXRzbzFt?=
 =?utf-8?B?blUrbW1oRWFudElSa3pkcTh0NDdGVnc1UTExc0FVSnZockttY2xCNlNkY2gy?=
 =?utf-8?B?MVk5VTJkWnFsS2lEMWJZMFNLZk1FalA0WWVyR2htSkJPUEkrYnFIeW9nMlRo?=
 =?utf-8?B?V2oxd0dWMzlnTG4wWTdOOXUra1E3MjRybUg5c3BSUXZxNVJEWjlrTXVuSmJT?=
 =?utf-8?B?WUYrcWw2T0QyWlJZaENaRWpIam9DbTVLVmJMRjAvM0crWXZJeXZlN25DTlM4?=
 =?utf-8?B?dmFFNmd5ZmlWWlpnTzJCK3ZyalZQVVgyZFBCVmx4M05aMnhuREdSa2M4d1dE?=
 =?utf-8?B?V1JGZHpCNzNHZ0txTmd1cHVVbEpUMi9yOTU2elZ1YWNvaUZOOEM0c1A2WlVN?=
 =?utf-8?B?VmVzd2NuOHA2REVYTFpHdkxRaFJxQ0JpWHprRXdlVHJaUlRndkl0VXd4TFVz?=
 =?utf-8?B?cStZVUh6RGhYRC9PMW1OUDJ2enA3ZUpPOXpmeHpLMzBzOFZSaVl4N2lzT0Fa?=
 =?utf-8?B?MmUrUWVaUWJDeXlHT0xBQXFSYmdtNGdPeTcrbUxLWVZPWk5OU0pRRHgrdGZU?=
 =?utf-8?B?cXVuK2xoTGxqb1YrbkhLaXN0UitjdVE1VU1FVkpLWTlZbVRVUzNBeEJyYy9R?=
 =?utf-8?B?MCtPVkpiQk1qMGNINkl0SVVBQnQwaW5lcVNuYnBIYlI0ZEFIbzkydDRDSDhi?=
 =?utf-8?B?K05hWjIvTjdMYmVaUDQ5ajJ4emR5a1ZNQnJ2VGdrdGJGaVVISVBlOFg4VWdU?=
 =?utf-8?B?QkJGMHVEVmFlOWJ6VTA3b2dhc255bWNyaUxLdDZrZlRWdVNjVUtaZUtzcHBk?=
 =?utf-8?B?WEhRam5OcVUrbTYxd0EyQlVRVENpWjJNZGtZUEJWOTVZMm5oWGU5L1NuTTU1?=
 =?utf-8?B?VmlSTGNiay9LWjZieC8yajNUVENONGQ4Q202Q0pCYm0wOTlPL1dkRjdlUTg5?=
 =?utf-8?B?NzRiVFRCa1BIbVBQQ1ZYajY4cS9tK1BEZk5MR3p4UlZsVmpJQkJsbXRCVUlM?=
 =?utf-8?B?N1dhMGNVNnBNRDJuVk9xaEJ0NnR5aHpUN1BIK0ZDT29ZV1pZY2pBeVVsSXI0?=
 =?utf-8?Q?T3EqRBA/Yvddyi5VQf6yu+pm+Sp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 359c3818-7be5-42cc-5776-08d8c60d5589
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2021 17:26:24.7992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /gu0vD4JPx0OHCILe54wEUXuGdYskcdPnJnXcM5yRwJEs8jbAr2gGupULsROa8/J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4208
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 30.01.21 um 19:47 schrieb Joe Perches:
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
>> Use semicolons and braces.
> Ping?
>   
>> Signed-off-by: Joe Perches <joe@perches.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Do you have commit rights to drm-misc-next?

>> ---
>>   drivers/dma-buf/st-dma-fence.c | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
>> index e593064341c8..c8a12d7ad71a 100644
>> --- a/drivers/dma-buf/st-dma-fence.c
>> +++ b/drivers/dma-buf/st-dma-fence.c
>> @@ -471,8 +471,11 @@ static int thread_signal_callback(void *arg)
>>   			dma_fence_signal(f1);
>>   
>>
>>   		smp_store_mb(cb.seen, false);
>> -		if (!f2 || dma_fence_add_callback(f2, &cb.cb, simple_callback))
>> -			miss++, cb.seen = true;
>> +		if (!f2 ||
>> +		    dma_fence_add_callback(f2, &cb.cb, simple_callback)) {
>> +			miss++;
>> +			cb.seen = true;
>> +		}
>>   
>>
>>   		if (!t->before)
>>   			dma_fence_signal(f1);
>