Subject: Re: [patch 8/8] stacktrace filtering for fault-injection
	capabilities
From: Don Mullis <dwm@meer.net>
To: Akinobu Mita <mita@miraclelinux.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de, akpm@osdl.org,
       Valdis.Kletnieks@vt.edu
In-Reply-To: <20060919090945.GE24271@miraclelinux.com>
References: <20060914102012.251231177@localhost.localdomain>
	 <20060914102033.462112306@localhost.localdomain>
	 <1158645471.2419.13.camel@localhost.localdomain>
	 <20060919090945.GE24271@miraclelinux.com>
Content-Type: text/plain
Date: Tue, 19 Sep 2006 10:35:27 -0700
Message-Id: <1158687327.2509.13.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 27

On Tue, 2006-09-19 at 17:09 +0800, Akinobu Mita wrote:
> On Mon, Sep 18, 2006 at 10:57:51PM -0700, Don Mullis wrote:
> > Push fault-injection entries earlier in the list, so that they appear
> > nested under DEBUG_KERNEL in menuconfig/xconfig.
> 
> Disabling the option Kernel debugging can hide all config options
> realated to fault-injection without this patch.
> 
> Do I misunderstand something?
> 

There's no problem with hiding per se, but rather with the indentation
level.  It's most natural for the user to have dependent options
indented under their "parent".  For an example, in "menuconfig" try
setting "Compile the kernel with frame unwind information";
notice that "Stack unwind support" appears immediately underneath
it, indented.  The indentation reminds the user why "Stack unwind
support" has appeared.

Note that several of the pre-existing, non-fault-injection options
under "Kernel debugging", are also broken in this way.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/