Subject: Re: [patch 7/8] process filtering for fault-injection capabilities
From: Don Mullis <dwm@meer.net>
To: Akinobu Mita <mita@miraclelinux.com>
Cc: linux-kernel@vger.kernel.org, ak@suse.de, akpm@osdl.org
In-Reply-To: <20060919090508.GC24271@miraclelinux.com>
References: <20060914102012.251231177@localhost.localdomain>
	 <20060914102032.989190948@localhost.localdomain>
	 <1158645291.2419.7.camel@localhost.localdomain>
	 <20060919090508.GC24271@miraclelinux.com>
Content-Type: text/plain
Date: Tue, 19 Sep 2006 10:38:30 -0700
Message-Id: <1158687510.2509.17.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 29

On Tue, 2006-09-19 at 17:05 +0800, Akinobu Mita wrote:
> On Mon, Sep 18, 2006 at 10:54:51PM -0700, Don Mullis wrote:
> > Add functionality to the process_filter variable: A negative argument
> > injects failures for only for pid==-process_filter, thereby permitting
> > per-process failures from boot time.
> > 
> 
> Is it better to add new filter for this purpose?
> Because someone may want to filter by tgid instead of pid.
> 
> - positive value is for task->pid
> - nevative value is for task->tgid

Your idea sounds good to me.

> > Add printk, called upon each failure injection.
> > 
> 
> This printk() will be very useful. But it is better to make
> configurable, and the pid is not reliable in interrupt context.

Okay.  We do need some output now, for testing.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/