Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210131205654.3379661-1-saravanak@google.com> <CAOMZO5AZgk0N8sN9=bGcWTcnju75TPVxQX3FbLpF=n-=JA-7-w@mail.gmail.com>
In-Reply-To: <CAOMZO5AZgk0N8sN9=bGcWTcnju75TPVxQX3FbLpF=n-=JA-7-w@mail.gmail.com>
From:   Saravana Kannan <saravanak@google.com>
Date:   Sun, 31 Jan 2021 18:22:37 -0800
Message-ID: <CAGETcx9YsjPtiBxJEybY5UTWNu-9e=FrYPVd1ORF9hz0M04w5Q@mail.gmail.com>
Subject: Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Martin Kaiser <martin@kaiser.cx>,
        Android Kernel Team <kernel-team@android.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Saravana,
>
> On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan <saravanak@google.com> wrote:
>
> > +static int __init imx_avic_init(struct device_node *node,
> > +                              struct device_node *parent)
> > +{
> > +       void __iomem *avic_base;
> > +
> > +       avic_base = of_iomap(node, 0);
> > +       BUG_ON(!avic_base);
> > +       mxc_init_irq(avic_base);
> > +       return 0;
> > +}
> > +
> > +IRQCHIP_DECLARE(imx_avic, "fsl,imx31-avic", imx_avic_init);
>
> Shouldn't the compatible be "fsl,avic" instead?

Fabio,

Ah yes. I had that too. I deleted the wrong one in the last minute
before sending it out. Thanks for catching it.

I'll wait to see if there are any other review comments before I send out v2.

Martin,

Please make this fix before you test it.

-Saravana