Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Feb 2021 15:06:46 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Felipe Balbi <balbi@kernel.org>,
        Wesley Cheng <wcheng@codeaurora.org>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "supporter:USB SUBSYSTEM open list:DESIGNWARE USB3 DRD IP DRIVER" 
        <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: usb: dwc3: gadget: skip pullup and set_speed after suspend
Message-ID: <20210201060646.GA188943@ubuntu>
MIME-Version: 1.0
In-Reply-To: <20210201054539.GA188887@ubuntu>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----dZHoiG3rfwxb_Py8wGLYailixDOP787k4OKmtNPLilWg7srF=_804b8_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20210120035123epcas2p2048f6d9896bd21f19d939a56fe0b6610@epcas2p2.samsung.com>
        <1611113968-102424-1-git-send-email-dh10.jung@samsung.com>
        <87ft2qgxle.fsf@kernel.org> <20210201054539.GA188887@ubuntu>
Precedence: bulk

------dZHoiG3rfwxb_Py8wGLYailixDOP787k4OKmtNPLilWg7srF=_804b8_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Sun, Jan 24, 2021 at 05:31:57PM +0200, Felipe Balbi wrote:
> 
> Hi,
> 
> Daehwan Jung <dh10.jung@samsung.com> writes:
> > Sometimes dwc3_gadget_pullup and dwc3_gadget_set_speed are called after
> > entering suspend. That's why it needs to check whether suspend
> >
> > 1. dwc3 sends disconnect uevent and turn off. (suspend)
> > 2. Platform side causes pullup or set_speed(e.g., adbd closes ffs node)
> > 3. It causes unexpected behavior like ITMON error.
> 
> please collect dwc3 trace events showing this problem.
> 
> -- 
> balbi

Hi, balbi

I'm sorry for late reply. I pulled in belo patch and that issue didn't occur

usb: dwc3: gadget: Restart DWC3 gadget when enabling pullup

@ Wesley cheng
But, I think it needs to modify pm_rumtime_put to pm_runtime_put_sync_suspend
for syncronization. pm_rumtime_put calls rumtime_idle not runtime_suspend
Please check it.

usb: dwc3: gadget: Allow runtime suspend if UDC unbinded

Best Regards,
Jung Daehwan

------dZHoiG3rfwxb_Py8wGLYailixDOP787k4OKmtNPLilWg7srF=_804b8_
Content-Type: text/plain; charset="utf-8"


------dZHoiG3rfwxb_Py8wGLYailixDOP787k4OKmtNPLilWg7srF=_804b8_--