Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3632215pxb; Sun, 31 Jan 2021 23:54:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJxUJ5uUrA0MMLa9SKHONqjvJKIe9XVgrwpnelEFFGhSsajFAbjXL0sdP8w3oWYAKAL789G5 X-Received: by 2002:a05:6402:378:: with SMTP id s24mr17911391edw.376.1612166050306; Sun, 31 Jan 2021 23:54:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612166050; cv=none; d=google.com; s=arc-20160816; b=drHeimmj8Px/cMLedHiJbGiqoyxp07PHefUOYp6dPm6TC/SPUAYs2AZKjB179zaGFy RIHa1MuxiAchS+6+NAJHbGe2gEtismHapMfFdkR9EAitzhDXfIoFLinlrUAmrsXA5DUt YOTm6NxxZ3nUTk7AmcDTtWhktO50dqbKwDmDnkeZOUROxZtGYW62o8dGofPnvoiobMzm T9GLewWim7qXvNEqBkHJzzu/c00mtKg/q0cl5WvW8jSU20ZpXvetQTb+/jucJBrAQye7 9KQvResIWsDvou/1JR6pdRBPSix9FXAyxtKJjjdFtsR06GmZh9l6PURhjxRdfj/v+qko 5jwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=ACZaLblXNzKhffH7NWNg7wREWziCX2lsW2j84cZYvLw=; b=taeZjpil6HkIgcIB8M2jGmAiMcTSvhU6Yf96pHxtgImiBJowt3R1PK/7+YVU0OXBX6 Up1mCHQ29idZJ85764J3sEQ6X+NHQgFqdT8F0Jd6bKYZa8Np2bfRXdlgGbPIgSU+VZRt KNBFI8SdDJDL3/ChIlf7U+dwKKgKEW5doxhcd8k+0GJBi3dTSkeL5zkjo4apGm0DGhbc yGi0sNy9Ykn0N3phbpbRXcvch4aPnskuy34+LmBB67Il/5g/eTOzzmPXoFXf8vlCPFjI AxobcdR2zuzFjYZbq5a3yeWq9MHMYPkzsM1h2AtlTHyL+uYZc67b2iw79FTEb3hGxIg1 LFvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu13si9263182ejb.588.2021.01.31.23.53.44; Sun, 31 Jan 2021 23:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232304AbhBAHxH (ORCPT + 99 others); Mon, 1 Feb 2021 02:53:07 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:46253 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232281AbhBAHxG (ORCPT ); Mon, 1 Feb 2021 02:53:06 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UNWyeD-_1612165931; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UNWyeD-_1612165931) by smtp.aliyun-inc.com(127.0.0.1); Mon, 01 Feb 2021 15:52:22 +0800 From: Jiapeng Chong To: jlayton@kernel.org Cc: idryomov@gmail.com, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ceph: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE Date: Mon, 1 Feb 2021 15:52:10 +0800 Message-Id: <1612165930-110076-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./fs/ceph/debugfs.c:347:0-23: WARNING: congestion_kb_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/ceph/debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c index 66989c8..617327e 100644 --- a/fs/ceph/debugfs.c +++ b/fs/ceph/debugfs.c @@ -344,8 +344,8 @@ static int congestion_kb_get(void *data, u64 *val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(congestion_kb_fops, congestion_kb_get, - congestion_kb_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(congestion_kb_fops, congestion_kb_get, + congestion_kb_set, "%llu\n"); void ceph_fs_debugfs_cleanup(struct ceph_fs_client *fsc) -- 1.8.3.1