Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Shradha Todi" <shradha.t@samsung.com>
To:     "'Joe Perches'" <joe@perches.com>, <linux-kernel@vger.kernel.org>
Cc:     <apw@canonical.com>, <pankaj.dubey@samsung.com>,
        "'Lakshay Mehra'" <l.mehra@samsung.com>
In-Reply-To: <a04109c80ded369fcbf8829d3d9461be7528226d.camel@perches.com>
Subject: RE: [PATCH] checkpatch: add warning for line space after "Fixes:"
 tag
Date:   Mon, 1 Feb 2021 16:54:14 +0530
Message-ID: <19f201d6f88c$cba69450$62f3bcf0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIMnVYZntJh0uLbgjY/HIK9LfURLgIA4OGsAOhu42+pwJPokA==
Content-Language: en-us
CMS-TYPE: 105P
References: <CGME20210128152646epcas5p3e0ceb57e0a2e668b4281b5733dd117d4@epcas5p3.samsung.com>
        <1611847603-15736-1-git-send-email-shradha.t@samsung.com>
        <a04109c80ded369fcbf8829d3d9461be7528226d.camel@perches.com>
Precedence: bulk

> -----Original Message-----
> From: Joe Perches <joe=40perches.com>
> Subject: Re: =5BPATCH=5D checkpatch: add warning for line space after
=22Fixes:=22 tag
>=20
> On Thu, 2021-01-28 at 20:56 +0530, Shradha Todi wrote:
> > Add a check to give warning for line break between Fixes tag
> > and signature tags as that is the commonly followed style.
> >
> > Also add a --fix option to delete space lines after =22Fixes:=22 tag.
> >
> > Signed-off-by: Lakshay Mehra <l.mehra=40samsung.com>
> > Signed-off-by: Shradha Todi <shradha.t=40samsung.com>
> > ---
> > =A0scripts/checkpatch.pl=20=7C=209=20+++++++++=0D=0A>=20>=20=A01=20file=
=20changed,=209=20insertions(+)=0D=0A>=20>=0D=0A>=20>=20diff=20--git=20a/sc=
ripts/checkpatch.pl=20b/scripts/checkpatch.pl=0D=0A>=20>=20index=2092e888e.=
.6c144c5=20100755=0D=0A>=20>=20---=20a/scripts/checkpatch.pl=0D=0A>=20>=20+=
++=20b/scripts/checkpatch.pl=0D=0A>=20>=20=40=40=20-3027,6=20+3027,15=20=40=
=40=20sub=20process=20=7B=0D=0A>=20>=20=A0=09=09=09=24commit_log_long_line=
=20=3D=201;=0D=0A>=20>=20=A0=09=09=7D=0D=0A>=20>=0D=0A>=20>=0D=0A>=20>=20+=
=23=20Check=20for=20no=20line=20break=20after=20Fixes=0D=0A>=20>=20+=09=09i=
f=20(=24line=20=3D=7E=20/=5E=5Cs*Fixes:/i=20&&=20=24rawlines=5B=24linenr=5D=
=20=3D=7E=0D=0A/=5E=5Cs*=24/)=20=7B=0D=0A>=20>=20+=09=09=09if=20(WARN(=22UN=
NECESSARY_NEWLINE=22,=0D=0A>=20>=20+=09=09=09=09=20=22Newline=20is=20not=20=
required=20after=20Fixes:=5Cn=22=20.=0D=0A>=20=24herecurr)=20&&=0D=0A>=20>=
=20+=09=09=09=20=20=20=20=24fix)=20=7B=0D=0A>=20>=20+=09=09=09=09fix_delete=
_line(=24fixlinenr+1,=20=24rawline);=0D=0A>=20>=20+=09=09=09=7D=0D=0A>=20>=
=20+=09=09=7D=0D=0A>=20=0D=0A>=20I=20think=20this=20isn't=20necessary=20and=
=20=24rawlines=5B=24linenr=5D=20may=20be=20not=20exist.=0D=0A>=20=0D=0A=0D=
=0AI=20recently=20submitted=20a=20patch=20with=20the=20fixes=20tag=20follow=
ed=20by=20a=20line=20break=0D=0Aand=20then=20SOB.=0D=0AI=20received=20a=20c=
omment=20saying=20=22no=20line=20space=20between=20Fixes=20and=20SOB=22=20=
=5B1=5D.=0D=0ASo=20my=20intention=20of=20adding=20this=20was=20to=20save=20=
the=20maintainers=20time=20from=20these=0D=0Asilly=20mistakes.=0D=0AAny=20s=
uggestions=20for=20improving=20this=20patch?=20Thanks=20a=20ton=20for=20the=
=20prompt=0D=0Areview.=0D=0A=5B1=5D:=20https://lkml.org/lkml/2021/1/6/291=
=0D=0A=0D=0A=0D=0A