Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Feb 2021 16:34:04 +0500
From:   Bilal Wasim <bilalwasim676@gmail.com>
To:     Matthias Brugger <matthias.bgg@gmail.com>
Cc:     linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        enric.balletbo@collabora.com, hsinyi@chromium.org,
        weiyi.lu@mediatek.com
Subject: Re: [PATCH 1/2] soc: mediatek: pm-domains: Use correct mask for
 bus_prot_clr
Message-ID: <20210201163404.0429fe00@a-VirtualBox>
In-Reply-To: <e4961c5e-db52-148d-c414-25f16101fb3f@gmail.com>
References: <20210201054542.1470695-1-Bilal.Wasim@imgtec.com>
        <20210201054542.1470695-2-Bilal.Wasim@imgtec.com>
        <e4961c5e-db52-148d-c414-25f16101fb3f@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 1 Feb 2021 09:59:47 +0100
Matthias Brugger <matthias.bgg@gmail.com> wrote:

> On 01/02/2021 06:45, Bilal Wasim wrote:
> > When "bus_prot_reg_update" is false, the driver should use
> > INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus
> > protection. However, the driver does not use this mask for
> > clearing bus protection which causes failure when booting
> > the imgtec gpu.
> > 
> > Corrected and tested with mt8173 chromebook.
> > 
> > Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
> > ---
> >  drivers/soc/mediatek/mtk-pm-domains.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h
> > b/drivers/soc/mediatek/mtk-pm-domains.h index
> > 141dc76054e6..7454c0b4f768 100644 ---
> > a/drivers/soc/mediatek/mtk-pm-domains.h +++
> > b/drivers/soc/mediatek/mtk-pm-domains.h @@ -60,7 +60,7 @@
> >  #define BUS_PROT_UPDATE_TOPAXI(_mask)
> > 	\ BUS_PROT_UPDATE(_mask,				\
> >  				INFRA_TOPAXI_PROTECTEN,
> > 	\
> > -				INFRA_TOPAXI_PROTECTEN_CLR,
> > \
> > +				INFRA_TOPAXI_PROTECTEN,
> > 	\  
> 
> BUS_PROT_UPDATE sets bus_prot_reg_update to true, which contradicts
> what you say in the commit message.
> 
> Please clarify.
> 

Yes, that's a problem in the commit message - Will fix and send out a
v2.

Thanks,
Bilal

> Regards,
> Matthias
> 
> >  				INFRA_TOPAXI_PROTECTSTA1)
> >  
> >  struct scpsys_bus_prot_data {
> >