Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 01 Feb 2021 12:06:36 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     David Brazdil <dbrazdil@google.com>
Cc:     Guenter Roeck <linux@roeck-us.net>, kvmarm@lists.cs.columbia.edu,
        Mark Rutland <mark.rutland@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        Will Deacon <will@kernel.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH v2 4/8] KVM: arm64: Generate hyp relocation data
In-Reply-To: <20210201104251.5foc64qq3ewgnhuz@google.com>
References: <20210105180541.65031-1-dbrazdil@google.com>
 <20210105180541.65031-5-dbrazdil@google.com>
 <20210129214325.GA195322@roeck-us.net> <87r1m2lets.wl-maz@kernel.org>
 <20210201104251.5foc64qq3ewgnhuz@google.com>
User-Agent: Roundcube Webmail/1.4.10
Message-ID: <12ccab367048c0df8c6bf1bf7e7d0c4f@kernel.org>
Precedence: bulk

Hi David,

On 2021-02-01 10:42, David Brazdil wrote:
> Thanks for writing the fix, Marc! There are no corner cases in this 
> code so
> if it boots, that should be a good indicator that all BE inputs were 
> converted.
> 
> Just one little thing I noticed below, otherwise:
> Acked-by: David Brazdil <dbrazdil@google.com>
> 
>>  arch/arm64/kvm/hyp/nvhe/Makefile     |  1 +
>>  arch/arm64/kvm/hyp/nvhe/gen-hyprel.c | 57 
>> ++++++++++++++++++++--------
>>  2 files changed, 42 insertions(+), 16 deletions(-)
>> 
>> diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile 
>> b/arch/arm64/kvm/hyp/nvhe/Makefile
>> index 268be1376f74..09d04dd50eb8 100644
>> --- a/arch/arm64/kvm/hyp/nvhe/Makefile
>> +++ b/arch/arm64/kvm/hyp/nvhe/Makefile
>> @@ -7,6 +7,7 @@ asflags-y := -D__KVM_NVHE_HYPERVISOR__
>>  ccflags-y := -D__KVM_NVHE_HYPERVISOR__
>> 
>>  hostprogs := gen-hyprel
>> +HOST_EXTRACFLAGS += -I$(srctree)/include
> This should be $(objtree), autoconf.h is generated.

Ah, well spotted. I build things in place, so it obviously never showed 
up.
Now fixed and pushed out with your Ack.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...