Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3865807pxb; Mon, 1 Feb 2021 06:43:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEodsD1GYiyX4XT9qDPKAy8D/LIG7vE1iTOUfy69uE0hsBYdsGrAbDKPVqn7Nq68ghaWPP X-Received: by 2002:a17:906:8690:: with SMTP id g16mr3380667ejx.113.1612190596865; Mon, 01 Feb 2021 06:43:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612190596; cv=none; d=google.com; s=arc-20160816; b=jd3B7Pr+pc/HqyBn8Vw0gvyrvY9x6NGFIQZiPDlIpikE///ncmdjm7/J7ZFf5pI5yn i+kWxxRBuq/EEuE6sahPDz5pi3rouPjrgSR6Bp7un0+c66DzK+HVqznCrxAflVokru1y ntTfmkIhbEQA31oV/KrgpVlmZygcOdjtq5MZPJwgBoollLJ+1D1SwS6sWBQdy+1bwwCQ vXbIRxZX57hSSC8quROSBtOT1Xc5cxEzITHHIyfzdiKWL2JiS87FD9Nf5+PQ1H8XppGk MYMD8eq+C+QY2INNWoSRoZhjGnoOc6ashijSdYfNuy7oYJiTf374sOJIjbR9TsUjzCdG Mc9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=zaPYx5DHLAGDsJIzg7OgWZStvA/r27aSLZaDjr3mTiL04SVEvkbpJ+a14wISW2JatV YmGcVCoY8fMuht72+r6WFTi3zzP7WB9UD4u/n6ZctixHbCAUVn3KqdaSAR8Z+MxmREgF 758PRNwhvAkxrJ6oACUjlvYgUo6o6vNBcMYtLa4hcGrOVhqogcgYeZuJ3cf7U6xb9u8/ LrRxErS3tlssUpUQcXtCYxjYuzr4MW5oSTRLpANJRLpaPtophM21dG41uOec+LPTPjI5 H8QkFF8me1gSEYADRoXiOxHZjYiEQwY1X9M8Ta7aScrl9O9cz6KZcFRdp1WKd7cKGXv3 I1Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=naPZ9ARq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si1302494eje.118.2021.02.01.06.42.51; Mon, 01 Feb 2021 06:43:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=naPZ9ARq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231327AbhBAOmS (ORCPT + 99 others); Mon, 1 Feb 2021 09:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbhBAOlU (ORCPT ); Mon, 1 Feb 2021 09:41:20 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A01DEC0617A7 for ; Mon, 1 Feb 2021 06:39:51 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 190so12862621wmz.0 for ; Mon, 01 Feb 2021 06:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=naPZ9ARqYCwvn9JncVu9nING3uu/kiOgXUcGuQTkTs7taI4zz63FAnlO5iWAGDACmP iNXjbxhfFKnGqviFm5BLJpk/Wu4a/5bfixHBp9hT6evXG6ay6VrzNclsUPnPqWPYmkD/ +w7SdPm01xRq9T6iWux+jV3mGiLopxx0qBwFqKjz/4hrdP/SFrID+68Z7Qk/DJAR79Eh vHDJNIff4gd6ZinI4ir9DLGQgSubMZQZcEV4PIb3oNELlQsB7ldgGt9YCfDhmAf2G/LJ rST08acpa2/lv7Z/NoEnoBnODJBs/6tuJql74+yjwK5N5xolpDFN3w3VpKgo3hFV/L2z o3eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=psxck1KMWyXDOgBCEv3jYVYq9cj2r/nvdYNmqCZ8a8o=; b=nHJnHrxrqjO4oiD8mkJhUYZUfw0rVXgeU3HuiMBzlgEDJncyUwnQFwVhn322mz+7mF 0PCYYOYBZb0TF5wglUkel3lmEcAY37lksa0guMhIJwv9ilg3A3/WGoMDP+bJ2/abW5ud 6P//7zpBFuVtD6PAk7DgDP5aNS9SY+BDTWYXW/9z02kuCaBX4SaWQC5CPgA/bXokUli9 DT7vIX6o6vOT4j84ele5uSR7RPhZjYV81xYqEPjkpsKY98a84mSV97L2IulrMgw2f2FD dMthcDaWGKL6Db9fSwETTxZa+dy9LJJyQgs0mLT05zrKd5PasnMFkYpa7nBDDH2zDqbq P82g== X-Gm-Message-State: AOAM531vFigSWt5/gWL/eQLNAoL5CBWpXUba3BQJ8xsuzh1YwK8i1dRb TSwtuIHCDc9Qa88zmASNpl6Hsw== X-Received: by 2002:a1c:5f89:: with SMTP id t131mr7153496wmb.148.1612190390339; Mon, 01 Feb 2021 06:39:50 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:39:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 06/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Date: Mon, 1 Feb 2021 14:39:26 +0000 Message-Id: <20210201143940.2070919-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: Function parameter or member 'deadline' not described in 'nv_pre_reset' drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_amd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c index 987967f976cb2..75b830eb3c542 100644 --- a/drivers/ata/pata_amd.c +++ b/drivers/ata/pata_amd.c @@ -167,7 +167,6 @@ static int amd_cable_detect(struct ata_port *ap) /** * amd_fifo_setup - set the PIO FIFO for ATA/ATAPI * @ap: ATA interface - * @adev: ATA device * * Set the PCI fifo for this device according to the devices present * on the bus at this point in time. We need to turn the post write buffer @@ -321,7 +320,8 @@ static unsigned long nv_mode_filter(struct ata_device *dev, /** * nv_probe_init - cable detection - * @lin: ATA link + * @link: ATA link + * @deadline: deadline jiffies for the operation * * Perform cable detection. The BIOS stores this in PCI config * space for us. -- 2.25.1