Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3869962pxb; Mon, 1 Feb 2021 06:49:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyal1JvTbzQTg3H/s+Gi+gZdRjO5X9P/GzgYYpTOeqVcP+dyLgtcb43XXIbcGjj/DCGOM5l X-Received: by 2002:a17:906:414e:: with SMTP id l14mr18481560ejk.476.1612190960516; Mon, 01 Feb 2021 06:49:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612190960; cv=none; d=google.com; s=arc-20160816; b=T6f0oazeT9HmoNquXVpHniebP6RZRb2/Lw8vpHC1sghYtjYiPQN9PoMW6gB0y0ASoA I3u1LQzZ+kEC4Y2Zo1MqBxddPQrSFbpJqXR2rTL2kKr4xtVxGGSDnjLozlGyi6dGVeBt t6IIWlr7p6pKvifgqBpxC1OdXZJgq3qzW7zzxMhZd7f3+D0GyoXocDB5aWtUabl+cjeC FcxU2eTKY7IczzKbJS3AP4wOpRyUbKO20M/1e74UzDuruAz1k+ResL6jXZXDlBSaPJFy V5wFJiRcl/Ppjb/iUNF5Na9xvd4V0vxh6uIDKXeZb2HSzOY+h1qKMaD1UuDBLmKe/oKH kQUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=g5vWVj1PxyNkZrXGNhPOfAFboUN5KZo8O3CdBy4NesU=; b=w/t2uAj5YNuFz0Kyw+BYSolLHi07LckxhuPfLqiNYi9ZzYb98nhHdj1tPLCDvzDFnW /raQfOAr2+XETVk0qm8L7TuZI5e4/6Y5y1N1jF4k50uTW3f9dQhUUMdUYMfopNzLrcR0 ujZAo5d/vU3y0tNC5I6fqXUl14AI4NrPRO9mpJfDXYB7dbFqE+H+MI6V1ivKNSBB/fkI 0kL+qHQ/CDhFaji1S0+2HJUYfS3AcNvL6+fYE88hbKHeQvqZIgRwHx6o2xlpdVhwh+O/ AMEwIW7Gm5+DH7FCJ4mispLoCWC2Onab1NdlHkYcpbwrMTTj79QNakbRGp8Re7urnOcf dhUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B4G7JSQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mp29si9705937ejc.304.2021.02.01.06.48.55; Mon, 01 Feb 2021 06:49:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B4G7JSQd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230157AbhBAOsV (ORCPT + 99 others); Mon, 1 Feb 2021 09:48:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbhBAOmV (ORCPT ); Mon, 1 Feb 2021 09:42:21 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04EE9C0611BC for ; Mon, 1 Feb 2021 06:40:06 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id a1so16848673wrq.6 for ; Mon, 01 Feb 2021 06:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g5vWVj1PxyNkZrXGNhPOfAFboUN5KZo8O3CdBy4NesU=; b=B4G7JSQdB4HA8+vgLEnKbugF9Ks5XEiRVYap9L6+9NSD+70VrhCfdfm7XnfeA2Dn15 FuZC8w+qFLpr86V5MFxKi/66rZoqFvOwKHShk6axOBXrEb7qs4C0J0KIo5V4kiujlvql U9rY5/Envm5r/vBZ3LVjS7VGPvqxN+cXTIJuGk2N83ODoP72l2QuCJi48ly+JROj9ptR BfIeTExkdYJuCwedU75cYifeXxEqNlZM2YkOAk3lAEM7mL/Je4x3TwgNY6fB5Ofy2vXM 1P/WNFhlit/SaOFpzYyCiwhnMqbZzlHuHZuSJj0PWKHjVXj7D/y/xE/da33gjtlpLkHn Qc6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g5vWVj1PxyNkZrXGNhPOfAFboUN5KZo8O3CdBy4NesU=; b=YA2QywqUo7HdQeJb3eBCFIlCitRG10AShmi3+s+itPrHnpxYU9dqhf4en0xQpwr5Tb e6QsHr8rK71NlwR/dny8f+bCAUYL5TJNVfVds2R2gHirdn9xQh5UwWbmI84uO6t85N5o PxNPmXhZXKmP7ozUchUX/eNA21PDgb0TI6yfwcbB8tdtUAbTpj1FwtjEeND5ReIMkxGl WdWxXESI1laU4UY+DELW0VR/knpynT2v1ldL3jWMcYKxwuLQyiOhtEzHsSwwyDEkJAJi SfgTju+dA90WYlCE+G1NGAgzGXB2ZtTKMk4AlPeI/7/fCVhHQpmmNl8P3q6s61DL+GVG DjwA== X-Gm-Message-State: AOAM531hpq74MgZIKH7cCKFzMpbJiBZaypi6n01ACKELH3jesmXZzhyk PCIqWBNSna4EbKfOKrSVi2rYYg== X-Received: by 2002:a5d:6a85:: with SMTP id s5mr17869868wru.283.1612190404772; Mon, 01 Feb 2021 06:40:04 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id h15sm27301359wrt.10.2021.02.01.06.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 06:40:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Jens Axboe , linux-ide@vger.kernel.org Subject: [PATCH 19/20] ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description Date: Mon, 1 Feb 2021 14:39:39 +0000 Message-Id: <20210201143940.2070919-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210201143940.2070919-1-lee.jones@linaro.org> References: <20210201143940.2070919-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/ata/pata_optidma.c:298: warning: expecting prototype for optidma_make_bits(). Prototype was for optidma_make_bits43() instead drivers/ata/pata_optidma.c:319: warning: Function parameter or member 'r_failed' not described in 'optidma_set_mode' drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev' not described in 'optiplus_with_udma' Cc: Jens Axboe Cc: linux-ide@vger.kernel.org Signed-off-by: Lee Jones --- drivers/ata/pata_optidma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_optidma.c b/drivers/ata/pata_optidma.c index fbcf0af34924d..f6278d9de3486 100644 --- a/drivers/ata/pata_optidma.c +++ b/drivers/ata/pata_optidma.c @@ -287,7 +287,7 @@ static void optiplus_set_dma_mode(struct ata_port *ap, struct ata_device *adev) } /** - * optidma_make_bits - PCI setup helper + * optidma_make_bits43 - PCI setup helper * @adev: ATA device * * Turn the ATA device setup into PCI configuration bits @@ -309,6 +309,7 @@ static u8 optidma_make_bits43(struct ata_device *adev) /** * optidma_set_mode - mode setup * @link: link to set up + * @r_failed: out parameter for failed device * * Use the standard setup to tune the chipset and then finalise the * configuration by writing the nibble of extra bits of data into @@ -354,7 +355,7 @@ static struct ata_port_operations optiplus_port_ops = { /** * optiplus_with_udma - Look for UDMA capable setup - * @pdev; ATA controller + * @pdev: ATA controller */ static int optiplus_with_udma(struct pci_dev *pdev) -- 2.25.1