Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3888823pxb; Mon, 1 Feb 2021 07:14:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuQwdyoXEbhFeIP+rXOpspXJHvGO/c3l3TaX/jSteJ57N7sGDzPH3sdNKtZQQtiewhw+nl X-Received: by 2002:a05:6402:31ae:: with SMTP id dj14mr19409594edb.364.1612192472829; Mon, 01 Feb 2021 07:14:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612192472; cv=none; d=google.com; s=arc-20160816; b=fmwB4w8+CaVGdZdrCBJ/mJqh2EYkF5j9cxBd3gAdggm8rLoIpNUdmRPBQNDBHZtvNA 8079chIex9Um8qsrq9S4jRK+e5zvwVuDR3aA5sMtRVAUco4Ti+cjPDQtcLkP0dDAa3M3 6l22Wxp5aLBI/x3pLIjnjtsgkhSPbeyLlFXp4ZeudBVCWCvNnlRc2iCmBikeR1PTblQ5 g8Y0hQqf9GbPa0a0rkqZXsHi2poYiCI/TjWAzQtnlsP9pJ+nBKOAVLCnBpSgY34T0yqw h280LSdGgdpKd/tdmrwqwnhoDOYJny9+fTIBRdI8q5HWT0wlvSKHk9me3tUZeUiwiq/G mG5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XzsWxXVEdEx1Ct2LvVjuNfLc6+Ok7yg9prITAZPniGw=; b=xiELk6JR7L314BDuzl+E4LgyS1diPILaswQVelumA21Zq5DEHSEI+RlhQdx5gi3f6M fIi1MCnb/b/faAVXywZ/zqtsEDdt6W6S6uKvNcUTEGHgoyIWqvwePX3LUFVk8PemEgcy 2sS+le2hHVg9yE4djFyyUO/uYrzYSNFIdKglyhznybQV6GdjLoikZxFAApP2pDsjVHTL eQD0iRpKY4dG/tN/pMfdvCizr+I7wVBVl/EkYpfj9B/MZJD5ATWcrlL24IgoNCtkwagH 5Ho/c+l8HBoil0zeJgIh9GqMkse0yRuWWP+qb4itG6dHWCeKAyQ3RZ83ZXIWtgIcPuDG mNMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r6xWdDyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si11005044ejb.223.2021.02.01.07.14.07; Mon, 01 Feb 2021 07:14:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r6xWdDyL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbhBAPMz (ORCPT + 99 others); Mon, 1 Feb 2021 10:12:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:38490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbhBAPMg (ORCPT ); Mon, 1 Feb 2021 10:12:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id DF28664E95; Mon, 1 Feb 2021 15:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612192316; bh=plbbhmJLAvPKBd3qsUegFrmdMR5VaLf7V7igSN1vMK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r6xWdDyLnnKHqrykiXwGTUHf2qcZbe5KXMOkxBF/tjri3Ehx0z3UqPwLVaWaqdbk2 TZphkq3gj5xPtVdA4dqCMTFGUl8t8w073x05q6IU6/44ZEndwG4eciCGwKv2GxzOIX xny6g0/CanaAu6pmn1rsXP8zXhuMgfS4OeZRLY4dThoUTus4CGwLBlwYfn1ZRTjhX9 pUC44j5+zVKvDHKBekTB+O/bfR142ULzUnOCMXneCB8wmpqAfcFhFWRM2w48XY6KDQ MUOSJnjtjGCEBHb946LsyA++DEhSg3aEKYHDveW9u42KgrDKBtY4/8bNBirPVmHV/I CRExGulIElu7g== Received: by pali.im (Postfix) id 6FD1F872; Mon, 1 Feb 2021 16:11:53 +0100 (CET) Date: Mon, 1 Feb 2021 16:11:53 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Yoshihiro Shimoda Cc: Mathias Nyman , Peter Chen , Mathias Nyman , Greg Kroah-Hartman , Jun Li , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk Message-ID: <20210201151153.zhk4tq5a3irnkahd@pali> References: <20201221150903.26630-1-pali@kernel.org> <20201223161847.10811-1-pali@kernel.org> <20201224055836.GB27629@b29397-desktop> <20210113232057.niqamgsqlaw7gojw@pali> <88b48c61-65e4-cc24-d90d-5fba92f05f27@linux.intel.com> <20210125142028.th4sscs27arhihm2@pali> <20210126090606.svpamobnrbdxyhgg@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210126090606.svpamobnrbdxyhgg@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 26 January 2021 10:06:06 Pali Rohár wrote: > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > > Hi Pali, > > > > I can see the benefit in this. > > > > In the xhci-plat case usb_create_hcd and usb_add_hcd are separate steps, and > > > > we could both copy the xhci_plat_priv .quirks and run the .init_qurks before > > > > adding the hcd. > > > > I guess the current way is inherited from pci case where the earliest place > > > > to do this after hcd is created is the hcd->driver->reset callback (which is > > > > set to xhci_pci_setup() or xhci_plat_setup()). > > > > > > > > xhci-rcar.c is using the .init_quirk to load firmware, we need to check with > > > > them if this change is ok. (added Yoshihiro Shimoda to cc) > > > > > > Yoshihiro, is this change OK? > > > > > > Can we move forward? I really need to now how to handle regression in > > > xhci-mvebu driver. And one option is with this patch... > > > > Thank you for asking me about this topic. I tested the patch, but unfortunately, > > this patch is possible to break a rcar platform because a phy initialization is > > needed before the firmware loading if the platform uses the phy. (Note that > > upstream code (salvator-common.dtsi) doesn't use the phy for xhci. But, > > if we use the phy on other board with this patch, the xhci will not work.) > > > > So, I think we need to add a new function pointer for your case. > > Ok, thank you for testing! I will try to come up with other solution to > mentioned mvebu-xhci issue. Hello! New version of this patch is in following thread, please review it: "[PATCH v2] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720" https://lore.kernel.org/linux-usb/20210201150803.7305-1-pali@kernel.org/ > > Best regards, > > Yoshihiro Shimoda > > > > > > Their firmware would be loaded before phy parts are initialized, usb bus > > > > registered, or roothub device allocated. > > > > > > > > Thanks > > > > -Mathias