Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3903633pxb; Mon, 1 Feb 2021 07:35:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJyomEYCJT3FNSmV+jefOcSBUFyhpMehk1Wr7wD8dVr0ruqSPBX0vCh6lQB2yTxIynt/tFZt X-Received: by 2002:a50:85c4:: with SMTP id q4mr19591335edh.7.1612193726833; Mon, 01 Feb 2021 07:35:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612193726; cv=none; d=google.com; s=arc-20160816; b=ieSEqewFs3khT8OIdabuki3JbH5JvmL0klA6NRDLmlyMly51I7yE9m+0Oem8MeEuXk bEEvxqC8g/WDCAtDnczySI3IVhXhPV29dVWn0dCk6L1jC4pzC0e9U9FglsX/v9fcL5/A 6gr8Tou5Zv65JUBWaHRLpaYbFGBDYF+0xY7sHq+IgVmmKuIeyOgGyofJPM2L9IeFrOZo vvCmDia+9JZ9aEvpL5g9B/kM0b5gS8Ot5hrxZZLwA0dTjpVY0X0Fsq+qyUtadS5vKjqt g3v6+UPE+Z2PJAXraCvPemn1p2oLzc6E1ZPmOtLMby4xtdajgzRArQwjIIfoThOo2iaJ 4r0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=LMR7gu4BhtwJQ85ih0F1WtLfDgjmoVB7dObeuqGXrtQ=; b=siol6QQUwzIlT9MGUlaJAlWpV8qQDEiHFJcGpsO3QVrXr61mmp/xZqS1Jk+utdmywX 1OuByY885N0FBG1ioQrbJbLoYTDLg9MBX/pKZTPsIvRlpF+o04OFGXXCfkibcGB+3cmV j0ODPdm0BXQ28PnpFHHx7hPBZkuUCNMrHQwtpZSmecNBCDhlMeYZbTTOXjmTj0dJXRLk 6te5OMFbK/HL2u8FbG8Z7tHyDeXp33gLn4p7HGuQq2kMQ+ZzFVK/M/kvzmHItuyFwtKe TO0harpnzizgx25FlhvYTKuMmUEDuA0C748zqv10AkJNXFsUz/Mw6/7KFmD6mawUzGRv w1cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a23si532184eda.386.2021.02.01.07.35.01; Mon, 01 Feb 2021 07:35:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231776AbhBAPbA (ORCPT + 99 others); Mon, 1 Feb 2021 10:31:00 -0500 Received: from mx0a-00128a01.pphosted.com ([148.163.135.77]:29916 "EHLO mx0a-00128a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbhBAOt1 (ORCPT ); Mon, 1 Feb 2021 09:49:27 -0500 Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 111El8bQ014311; Mon, 1 Feb 2021 09:48:33 -0500 Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com with ESMTP id 36dbucuqa6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Feb 2021 09:48:32 -0500 Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 111EmV4P030263 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 Feb 2021 09:48:31 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.721.2; Mon, 1 Feb 2021 09:48:30 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.721.2 via Frontend Transport; Mon, 1 Feb 2021 09:48:30 -0500 Received: from localhost.localdomain ([10.48.65.12]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 111EmNu9027350; Mon, 1 Feb 2021 09:48:29 -0500 From: Alexandru Ardelean To: , CC: , , , , , , , Alexandru Ardelean Subject: [PATCH v3 03/11] iio: core-trigger: make iio_device_register_trigger_consumer() an int return Date: Mon, 1 Feb 2021 16:50:57 +0200 Message-ID: <20210201145105.20459-4-alexandru.ardelean@analog.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210201145105.20459-1-alexandru.ardelean@analog.com> References: <20210201145105.20459-1-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Type: text/plain X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-01_06:2021-01-29,2021-02-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=999 spamscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102010079 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oddly enough the noop function is an int-return. This one seems to be void. This change converts it to int, because we want to change how groups are registered. With that change this function could error out with -ENOMEM. Signed-off-by: Alexandru Ardelean --- drivers/iio/iio_core_trigger.h | 4 +++- drivers/iio/industrialio-trigger.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/iio_core_trigger.h b/drivers/iio/iio_core_trigger.h index 374816bc3e73..e1a56824e07f 100644 --- a/drivers/iio/iio_core_trigger.h +++ b/drivers/iio/iio_core_trigger.h @@ -9,8 +9,10 @@ /** * iio_device_register_trigger_consumer() - set up an iio_dev to use triggers * @indio_dev: iio_dev associated with the device that will consume the trigger + * + * Return 0 if successful, negative otherwise **/ -void iio_device_register_trigger_consumer(struct iio_dev *indio_dev); +int iio_device_register_trigger_consumer(struct iio_dev *indio_dev); /** * iio_device_unregister_trigger_consumer() - reverse the registration process diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c index ea3c9859b258..438d5012e8b8 100644 --- a/drivers/iio/industrialio-trigger.c +++ b/drivers/iio/industrialio-trigger.c @@ -692,10 +692,12 @@ int iio_trigger_validate_own_device(struct iio_trigger *trig, } EXPORT_SYMBOL(iio_trigger_validate_own_device); -void iio_device_register_trigger_consumer(struct iio_dev *indio_dev) +int iio_device_register_trigger_consumer(struct iio_dev *indio_dev) { indio_dev->groups[indio_dev->groupcounter++] = &iio_trigger_consumer_attr_group; + + return 0; } void iio_device_unregister_trigger_consumer(struct iio_dev *indio_dev) -- 2.17.1