Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3926703pxb; Mon, 1 Feb 2021 08:08:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwisnuvd0blbCXjk9MhS/Au4f1CHiAVkmmW4cB+MXKntAO2MMNZ2Jlp+Swrhh1Y+xLY7zwM X-Received: by 2002:a17:906:1c17:: with SMTP id k23mr18119314ejg.255.1612195691279; Mon, 01 Feb 2021 08:08:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612195691; cv=none; d=google.com; s=arc-20160816; b=pH6uz7UdhGje6k3O2QQXgYthpLFtIJaBKroW02Ba9Gp7+fJyG1hX+6KvbfwUE7E/Jr RcgdaTxU55TnCOcARznlipgUJhNFDbpp+lJbMB5EHdvb2U8501t6q+Ikv/KAaI4m/LeD Ofo3V/u2scdOwkvkZ/49yBHbJ7mSVFBtP/Kbo7u74wvts2Al4zD1h5I+WEBqhfmb6SHw BxlUqyXGAg6FGHTQg1MCebwAxMDTyEeOt1g30zYBIwF92X5KjyIiHja4av/tIAO6Wkjw yrbizZTQtFbrsPx1IX0rikmuwjby6YV1gNLq0CO5gJMWlurpUBehSu+Z7g2TCE48aDfn QfTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=u5JyiTicijAx2VNhdwbCCkttZDT+qw+sxNkaVbLajiM=; b=XDSbky8K/ObuZfEIgq50gN3hsLaKdoYlYKNXvp0sZC1uf3wQ5453lYk9v4J4VKaXBX BEjoTDj0U//GL3/76ImHM5XMQu/KlgOMqSNx7skPBQnYNni+BzcUSRGA5rieFaiyA8yi sh7v4FfhJ8BxxYSVZMsLDkPP9OWlrcR+xGjPtWCdczqnxb3qV3vyQFl/dpcv8hVVkDYq fR9FIW98u2jxrx/87k+xD9HeP2ZRaNiRrUCqv7TGIkcvPu2wipRtD9E85UUb/qSVk6Ja vyiQQizML9ujp/0qTC9vDY2+5DN/HYg+X0uiIOgrCcUePlAl9Pu5MT9o0zKWR2nVXDH5 n/ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id md19si10376098ejb.134.2021.02.01.08.07.43; Mon, 01 Feb 2021 08:08:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhBAQGV (ORCPT + 99 others); Mon, 1 Feb 2021 11:06:21 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:33297 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbhBAQFu (ORCPT ); Mon, 1 Feb 2021 11:05:50 -0500 Received: from marcel-macbook.holtmann.net (p4fefcdd8.dip0.t-ipconnect.de [79.239.205.216]) by mail.holtmann.org (Postfix) with ESMTPSA id 513A5CED21; Mon, 1 Feb 2021 17:12:31 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH v3] Bluetooth: Skip eSCO 2M params when not supported From: Marcel Holtmann In-Reply-To: <20210129135322.v3.1.I7d3819e3c406b20307a56fe96159e8f842f72d89@changeid> Date: Mon, 1 Feb 2021 17:05:04 +0100 Cc: Bluetooth Kernel Mailing List , CrosBT Upstreaming , Abhishek Pandit-Subedi , "David S. Miller" , Jakub Kicinski , Johan Hedberg , LKML , netdev@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <57D64568-5DCB-4FAA-A23F-D16A2D7551A1@holtmann.org> References: <20210129135322.v3.1.I7d3819e3c406b20307a56fe96159e8f842f72d89@changeid> To: Yu Liu X-Mailer: Apple Mail (2.3654.40.0.2.32) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yu, > If a peer device doesn't support eSCO 2M we should skip the params that > use it when setting up sync connection since they will always fail. > > Signed-off-by: Yu Liu > Reviewed-by: Abhishek Pandit-Subedi > --- > > Changes in v3: > - Use pkt_type instead of adding new field > > Changes in v2: > - Fix title > > Changes in v1: > - Initial change > > include/net/bluetooth/hci_core.h | 1 + > net/bluetooth/hci_conn.c | 20 ++++++++++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel