Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable
 fw_devlink=on by default
To:     Saravana Kannan <saravanak@google.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Marc Zyngier <maz@kernel.org>,
        Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
        Kever Yang <kever.yang@rock-chips.com>,
        Android Kernel Team <kernel-team@android.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20210122193600.1415639-1-saravanak@google.com>
 <544ad0e4-0954-274c-8e77-866aaa5661a8@gmail.com>
 <CAGETcx_CYKczo+geD7yDo+T2+_-tgGYwtjR-2sMPQYHuz-wAgw@mail.gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <09502076-02e9-39ee-e432-24260696a927@gmail.com>
Date:   Mon, 1 Feb 2021 19:49:25 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
MIME-Version: 1.0
In-Reply-To: <CAGETcx_CYKczo+geD7yDo+T2+_-tgGYwtjR-2sMPQYHuz-wAgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

01.02.2021 00:28, Saravana Kannan пишет:
>> This patch causes these new errors on NVIDIA Tegra30 Nexus 7 using recent linux-next:
>>
>>  gpio-1022 (cpu-pwr-req-hog): hogged as input
>>  max77620-pinctrl max77620-pinctrl: pin gpio4 already requested by max77620-pinctrl; cannot claim for gpiochip1
>>  max77620-pinctrl max77620-pinctrl: pin-4 (gpiochip1) status -22
>>  max77620-pinctrl max77620-pinctrl: could not request pin 4 (gpio4) from group gpio4  on device max77620-pinctrl
>>  gpio_stub_drv gpiochip1: Error applying setting, reverse things back
>>  gpio_stub_drv: probe of gpiochip1 failed with error -22
>>
>> Please fix, thanks in advance.
> I have a partial guess on why this is happening. So can you try this patch?
> 
> Thanks,
> Saravana
> 
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4213,6 +4213,8 @@ static int gpio_stub_drv_probe(struct device *dev)
>          * gpio_device of the GPIO chip with the firmware node and then simply
>          * bind it to this stub driver.
>          */
> +       if (dev->fwnode && dev->fwnode->dev != dev)
> +               return -EBUSY;
>         return 0;
>  }

This change doesn't help, exactly the same errors are still there.