Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Feb 2021 18:29:22 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Hermann Lauer <Hermann.Lauer@iwr.uni-heidelberg.de>
Cc:     linux-arm-kernel@lists.infradead.org, wens@csie.org,
        jernej.skrabec@siol.net, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode
Message-ID: <20210201172922.vnelblciqun46szk@gilmour>
References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de>
 <20210128094040.GD11559@lemon.iwr.uni-heidelberg.de>
 <20210128111842.GA11919@lemon.iwr.uni-heidelberg.de>
 <20210128145937.vtdi4e2aih7milmt@gilmour>
 <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zp4sfxddimiu2ffh"
Content-Disposition: inline
In-Reply-To: <20210201120803.GF15207@lemon.iwr.uni-heidelberg.de>
Precedence: bulk


--zp4sfxddimiu2ffh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 01, 2021 at 01:08:03PM +0100, Hermann Lauer wrote:
> On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote:
> > On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.=
de wrote:
> > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> > > packet loss rates. The realtek phy driver overrides the settings of t=
he
> > > pull ups for the delays, so fix this for BananaPro.
> > >    =20
> > > Fix the phy-mode description to correctly reflect this so that the
> > > implementation doesn't reconfigure the delays incorrectly. This
> > > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> > > rx/tx delay config").
> > >=20
> > > Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro boa=
rd")
> > > Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
> >=20
> > Applied since it's a fix simple enough, but please provide a changelog
> > between versions.
>=20
> v3 added the correct fixes tag, where the problem originated (initial com=
mit
> of banana pro device tree). That worked in the past until a change in
> the phy device driver for realtek phy on banana pro overrode the
> phyical configuration of the hardware pull-ups.
>=20
> v4 added the commit which implemented that driver change (shamelessly sto=
len
> from the commit of the fix of the identical problem on the banana pi)

Thanks :)

For future patches make sure to have that description either in a cover
letter or below the --- after your commit log

Maxime

--zp4sfxddimiu2ffh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYBg6cgAKCRDj7w1vZxhR
xZh1AQCq36tZ5n4FdroUZgnTNa601zD0ugKC3008GoIsUQUJBAD/TFa/YIFAgisI
zGDcarCcGZBBkXx/HEiCI1i0+wIGDQA=
=gu8h
-----END PGP SIGNATURE-----

--zp4sfxddimiu2ffh--